Repository navigation
pico_double: align RP2350 lookup tables - #3288
Open
Mohdaasim18 wants to merge 1 commit into
Open
Mohdaasim18 wants to merge 1 commit into
Mohdaasim18 wants to merge 1 commit into
Conversation
Signed-off-by: Aasim <mohdasimmmmm@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align the
rtwopiandtrigtablookup table sections to 4-byte boundaries in the RP2350 Cortex-M33 assembly implementation.The
double_sectionmacro selects executable sections but does not explicitly specify their alignment. With the ARM LLVM Embedded Toolchain, these sections were emitted with only 1-byte alignment.This change adds
.p2align 2before both tables, ensuring 4-byte section alignment.Verification
pico_double_test_pico_dcpusing ARM LLVM Embedded Toolchain 19.1.5.llvm-readelf.git diff --checkpasses.Hardware validation on RP2350 has not yet been performed.
Fixes #3183