Skip to content

pico_double: align RP2350 lookup tables - #3288

Open
Mohdaasim18 wants to merge 1 commit into
raspberrypi:developfrom
Mohdaasim18:fix-rp2350-double-alignment
Open

Mohdaasim18 wants to merge 1 commit into
raspberrypi:developfrom
Mohdaasim18:fix-rp2350-double-alignment

Conversation

@Mohdaasim18

Copy link
Copy Markdown

Summary

Align the rtwopi and trigtab lookup table sections to 4-byte boundaries in the RP2350 Cortex-M33 assembly implementation.

The double_section macro selects executable sections but does not explicitly specify their alignment. With the ARM LLVM Embedded Toolchain, these sections were emitted with only 1-byte alignment.

This change adds .p2align 2 before both tables, ensuring 4-byte section alignment.

Verification

  • Built pico_double_test_pico_dcp using ARM LLVM Embedded Toolchain 19.1.5.
  • Inspected the generated object file using llvm-readelf.
  • Before the change, both sections had alignment 1.
  • After the change, both sections have alignment 4.
  • git diff --check passes.

Hardware validation on RP2350 has not yet been performed.

Fixes #3183

Signed-off-by: Aasim <mohdasimmmmm@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant