Repository navigation
Change pico_low_power CMakeLists.txt target_include_directories to use _headers - #3287
Open
Richard-CRT wants to merge 1 commit into
Open
Richard-CRT wants to merge 1 commit into
Richard-CRT wants to merge 1 commit into
Conversation
This matches pico_rand and pico_flash etc behaviour, where headers are available via _headers suffix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3286
Title, causing static libraries that link PRIVATE headers using the
_headerssuffixes e.g.To cause
fatal error: pico/low_power.h: No such file or directory.Problem:
target_include_directories(pico_low_power INTERFACE ${CMAKE_CURRENT_LIST_DIR}/include)Compare to below examples:
pico_rand
target_include_directories(pico_rand_headers SYSTEM INTERFACE ${CMAKE_CURRENT_LIST_DIR}/include)pico_flash
target_include_directories(pico_flash_headers SYSTEM INTERFACE ${CMAKE_CURRENT_LIST_DIR}/include)Solution:
Add
_headerson line 7 ofsrc/rp2_common/pico_low_power/CMakeLists.txtto result intarget_include_directories(pico_low_power_headers INTERFACE ${CMAKE_CURRENT_LIST_DIR}/include)