Skip to content

ipa: rpi: agc: Clamp digital gain to avoid saturation issues #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
davidplowman wants to merge 1 commit into from
Closed

ipa: rpi: agc: Clamp digital gain to avoid saturation issues #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/ipa/rpi/controller/rpi/agc_channel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,8 +941,8 @@ void AgcChannel::divideUpExposure()
/* Finally work out the digital gain that we will need. */
filtered_.totalExposureNoDG = analogueGain * exposureTime;
double digitalGain = filtered_.totalExposure / filtered_.totalExposureNoDG;
/* Limit dg by what is allowed. */
digitalGain = std::min(digitalGain, config_.maxDigitalGain);
/* Limit dg by what is allowed (and to 1.0 to avoid saturation issues). */
digitalGain = std::clamp(digitalGain, 1.0, config_.maxDigitalGain);
/* Update total exposure, in case the dg went down. */
filtered_.totalExposure = filtered_.totalExposureNoDG * digitalGain;

Expand Down