Move board selection logic into a dedicated header - #208
Draft
carlwhamilton wants to merge 2 commits into
Draft
Conversation
Added "_CONFIG" to the include guards for the board configuration headers. This will help avoid collisions and confusion with other, similarly named headers.
The small amount of logic to select and configure the target board has moved to a new, dedicated header: board_config.h. This will allow future changes to board selection and configuration to be more easily isolated and prevent probe_config.h from being polluted by board-related shenanigans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls the board selection logic out of probe_config.h and moves it to its own, dedicated header file: include/board_config.h. Isolating this logic will reduce the blast radius of any future commits to modify or add board-specific configuration details.
The include guards in the existing board configuration headers are also extended to fully match their filenames.
These changes are cosmetic only; they shouldn't change the overall build process or resulting binaries.
#210