Repository navigation
fix(geom3d): return the intersection point of two lines - #273
Open
Doribelove wants to merge 1 commit into
Open
Doribelove wants to merge 1 commit into
Doribelove wants to merge 1 commit into
Conversation
Signed-off-by: 李永祺 <doribelove@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line3.intersects()returns a(3, 3)array for intersecting lines instead of the documented(3,)intersection point:The final multiplication in the old expression broadcasts a matrix. Normalizing the cross product also rejects some valid lines represented with small Plücker coordinates.
After the existing intersection predicate succeeds, reuse
closest_to_line()to obtain the intersection point. Keep the predicate, tolerance andNoneresult for parallel, coincident and skew lines unchanged. Correct the method's malformed related-method links.Add 18 regression cases covering the origin and translated intersections, nonorthogonal and spatial directions, either operand order, positive/negative and unequal Plücker scales, and nonintersecting controls.
Validation with current upstream
41e0a4d:git diff --checkpass.