Repository navigation
Conversation
antonsoo
requested review from
jbarry-bdai,
petercorke and
taughz
as code owners
October 12, 2026 08:56
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twist2.poleandTwist3.poledivide the cross product by the angular magnitude. The closest point on the screw axis requires its square: the cross product already contains one factor of angular speed. Consequently, scaling a twist currently moves its reported axis.Use
w**2in 2D anddot(w, w)in 3D. The zero-angular case keeps its existing undefined behavior.The regression checks cover signed speeds, off-origin axes and nonzero screw pitch. They verify that finite motion leaves an axis point fixed except for translation along the axis. Twelve of the 15 cases fail before the fix. On a camera-reconstruction fixture, 680 incorrect axis estimates become zero across 768 scaled 2D/3D increments; independent least-squares axis references agree within
1.5e-14. Ordinary transform outputs remain identical. Full suite: 362 passed, 3 existing skips; project pre-commit hooks pass. Linux/Python 3.12.