Repository navigation
Conversation
antonsoo
requested review from
jbarry-bdai,
petercorke and
taughz
as code owners
October 12, 2026 08:54
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twist3.expdocuments applying one integration step to every twist in a sequence, but currently raisesValueError: length mismatch. TheSE3conversion also rejects that case. The correspondingTwist2methods fail too, including matched per-twist steps inSE2.Handle the shared scalar step in all four methods, and match individual steps in
Twist2.SE2. Check degree-mode warnings per twist so that path works for sequences as well. Singleton expansion and mismatched-length rejection are retained.Validation: 20 focused cases compare the results to independent SciPy matrix exponentials (17 fail before). A 717-row camera-reconstruction fixture exercises 96 motion increments in 2D and 3D: all 21 formerly aborting sequence workflows complete, and transformed points agree with the independent reference within
4e-14. Ordinary single-twist output hashes are unchanged. Full suite: 367 passed, 3 existing skips; project pre-commit hooks pass. Linux/Python 3.12.