feat(ironic): add network device credentials config - #2408
Open
khackworth wants to merge 3 commits into
Open
khackworth wants to merge 3 commits into
khackworth wants to merge 3 commits into
Conversation
khackworth
force-pushed
the
add-network-device-credentials-config
branch
from
September 25, 2026 14:19
45dfaf5 to
2016a8e
Compare
cardoe
requested changes
Sep 25, 2026
cardoe
left a comment
cardoe
left a comment
Contributor
There was a problem hiding this comment.
We really don't need to mess with mounting paths. We should use Oslo.config for anything we need to load.
- adds config and helper util to read creds - integrates with puc-2053
- read in network-device-credentials-ini into etcSources as optional - __init__.py to load panos, f5 and service_accounts - helper to read from oslo.config - enroll-fw to add network-device-credentials (future use?)
khackworth
force-pushed
the
add-network-device-credentials-config
branch
from
September 28, 2026 17:04
70f5ff7 to
8122093
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding volume mount for network-device-credentials secret
Adding oslo.config for netdev creds
includes get_credential and get_panos_credentials helpers