feat(nautobot-target-proxy): Moves nautobot-target-proxy in to Understack#1957
Open
nicholaskuechler wants to merge 4 commits intomainfrom
Open
feat(nautobot-target-proxy): Moves nautobot-target-proxy in to Understack#1957nicholaskuechler wants to merge 4 commits intomainfrom
nicholaskuechler wants to merge 4 commits intomainfrom
Conversation
nicholaskuechler
force-pushed
the
PUC-1620-20260415-1400
branch
2 times, most recently
from
b424584 to
e599634
Compare
nicholaskuechler
changed the title
nicholaskuechler
force-pushed
the
PUC-1620-20260415-1400
branch
12 times, most recently
from
62e2f22 to
be5b67e
Compare
cardoe
reviewed
Apr 21, 2026
nicholaskuechler
force-pushed
the
PUC-1620-20260415-1400
branch
from
be5b67e to
4f9faec
Compare
cardoe
reviewed
Apr 21, 2026
| annotations: | ||
| argocd.argoproj.io/sync-options: Delete=false | ||
| syncOptions: | ||
| - CreateNamespace=true |
Contributor
There was a problem hiding this comment.
The namespace is probably created by the site worker so we don't want this line.
Collaborator
Author
There was a problem hiding this comment.
I question whether it matters, but if it does matter, I think the assumption that nautobot-worker creates it is wrong, since nautobot-target-proxy comes before nautobot-worker alphabetically.
cardoe
reviewed
Apr 21, 2026
Comment on lines
+36
to
+38
| managedNamespaceMetadata: | ||
| annotations: | ||
| argocd.argoproj.io/sync-options: Delete=false |
Contributor
There was a problem hiding this comment.
We won't want this if the namespace is created by the site worker
Collaborator
Author
There was a problem hiding this comment.
Doesn't this protect against deletions which is what we want?
nicholaskuechler
force-pushed
the
PUC-1620-20260415-1400
branch
8 times, most recently
from
b5a465c to
ca31da3
Compare
nicholaskuechler
force-pushed
the
PUC-1620-20260415-1400
branch
from
ca31da3 to
6db2c54
Compare
… in to understack repo
nicholaskuechler
force-pushed
the
PUC-1620-20260415-1400
branch
from
6db2c54 to
897b198
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.