Conversation
skrobul
left a comment
skrobul
left a comment
There was a problem hiding this comment.
LGTM, needs a cosmetic fix (see CI)
stevekeay
force-pushed
the
rework-enrol-workflow
branch
from
eac00d9 to
82c1b4e
Compare
stevekeay
force-pushed
the
rework-enrol-workflow
branch
6 times, most recently
from
9bba6db to
3e839e8
Compare
This was used to influence the "pxe" boot configuration during enrol but we don't need it any more because we now set the "pxe" flag on all candidate interfaces during enrol, and then we set it properly once the full agent inspection data is in available.
stevekeay
force-pushed
the
rework-enrol-workflow
branch
3 times, most recently
from
c6ac876 to
78960b1
Compare
Virtual-media is slightly more robust that normal PXE/HTTP boot for the initial inspection, because at that time we don't have the full picture of the network cabling and so we can't make the exact final settings for the BIOS and for Ironic.
stevekeay
force-pushed
the
rework-enrol-workflow
branch
3 times, most recently
from
cb87463 to
e61bd42
Compare
stevekeay
force-pushed
the
rework-enrol-workflow
branch
from
e61bd42 to
5e7993c
Compare
stevekeay
force-pushed
the
rework-enrol-workflow
branch
4 times, most recently
from
db55c21 to
4a7074b
Compare
skrobul
left a comment
skrobul
left a comment
There was a problem hiding this comment.
it looks good - one small nit - would you be opposed standardising on the enroll spelling to avoid potential mistakes? (it will work as is now, but it feels like maintaining two versions can lead to unnecessary issues)
| bmc_description = "Dedicated iDRAC interface" | ||
| else: | ||
| bmc_name = "iLO" | ||
| bmc_description = str(data.get("name")) |
There was a problem hiding this comment.
else -> raise HardwareNotSupportedError (or similar)?
There was a problem hiding this comment.
fixed in e633b7c although I think this logic was originally used for creating things in Nautobot, and that responsibility moved elsewhere. This code might shrink away altogether in future.
I changed the spelling for comments and private references, but I left the physical network name as "enrol" for now because this is referenced externally - changing it requires that we first change the undersync API, to have it accept the new value. |
2 participants
Make enroll leverage more of the openstack features.
We perform virtual-media boot for the initial inspection.
We update our handling of ironic ports to make sure the proper values are set at all points in the server life-cycle.