Skip to content

perf(rules): Retire LOL driver rules #692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rabbitstack merged 1 commit into from
Jul 6, 2026
+57 −193
Merged

perf(rules): Retire LOL driver rules #692

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 2 additions & 16 deletions pkg/filter/accessor_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,9 +675,7 @@ func (t *threadAccessor) Get(f Field, e *event.Event) (params.Value, error) {
// fileAccessor extracts file specific values.
type fileAccessor struct{}

func (fileAccessor) SetFields(fields []Field) {
initLOLDriversClient(fields)
}
func (fileAccessor) SetFields(fields []Field) {}
func (fileAccessor) SetSegments([]fields.Segment) {}

func (fileAccessor) IsFieldAccessible(e *event.Event) bool { return e.Category == event.File }
Expand Down Expand Up @@ -728,11 +726,6 @@ func (l *fileAccessor) Get(f Field, e *event.Event) (params.Value, error) {
return e.GetParamAsString(params.FileViewSectionType), nil
case fields.FileViewProtection:
return e.GetParamAsString(params.MemProtect), nil
case fields.FileIsDriverVulnerable, fields.FileIsDriverMalicious:
if e.IsCreateDisposition() && e.IsSuccess() {
return isLOLDriver(f.Name, e)
}
return false, nil
case fields.FileIsDLL, fields.FileIsDriver, fields.FileIsExecutable:
if e.IsCreateDisposition() && e.IsSuccess() {
return getFileInfo(f.Name, e)
Expand Down Expand Up @@ -763,9 +756,7 @@ func (l *fileAccessor) Get(f Field, e *event.Event) (params.Value, error) {
// moduleAccessor extracts module (DLL, executable, driver) event values.
type moduleAccessor struct{}

func (moduleAccessor) SetFields(fields []Field) {
initLOLDriversClient(fields)
}
func (moduleAccessor) SetFields(fields []Field) {}
func (moduleAccessor) SetSegments([]fields.Segment) {}

func (moduleAccessor) IsFieldAccessible(e *event.Event) bool {
Expand Down Expand Up @@ -833,11 +824,6 @@ func (m *moduleAccessor) Get(f Field, e *event.Event) (params.Value, error) {
return e.Params.GetTime(params.ModuleCertNotBefore)
case fields.ImageCertAfter, fields.ModuleSignatureAfter, fields.DllSignatureAfter:
return e.Params.GetTime(params.ModuleCertNotAfter)
case fields.ImageIsDriverVulnerable, fields.ImageIsDriverMalicious, fields.ModuleIsDriverVulnerable, fields.ModuleIsDriverMalicious:
if e.IsLoadModule() {
return isLOLDriver(f.Name, e)
}
return false, nil
case fields.ImageIsDLL, fields.ModuleIsDLL, fields.ImageIsDriver,
fields.ModuleIsDriver, fields.ImageIsExecutable, fields.ModuleIsExecutable,
fields.ImageIsDotnet, fields.ModuleIsDotnet, fields.DllIsDotnet:
Expand Down
Loading
Loading