Skip to content

perf(processor): Remove costly mmaped file queries #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rabbitstack merged 1 commit into from
Jul 3, 2026
Merged

perf(processor): Remove costly mmaped file queries #691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions internal/etw/processors/fs_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,7 @@ import (
"github.com/rabbitstack/fibratus/pkg/handle"
htypes "github.com/rabbitstack/fibratus/pkg/handle/types"
"github.com/rabbitstack/fibratus/pkg/ps"
"github.com/rabbitstack/fibratus/pkg/sys"
"github.com/rabbitstack/fibratus/pkg/util/signature"
"github.com/rabbitstack/fibratus/pkg/util/va"
"golang.org/x/sys/windows"
)

Expand Down Expand Up @@ -110,16 +108,6 @@ func (f *fsProcessor) processEvent(e *event.Event) (*event.Event, error) {
if fileinfo != nil {
totalMapRundownFiles.Add(1)
e.AppendParam(params.FilePath, params.Path, fileinfo.Name)
} else {
// if the view of section is backed by the data/image file
// try to get the mapped file name and append it to params
sec := e.Params.MustGetUint32(params.FileViewSectionType)
isMapped := sec != va.SectionPagefile && sec != va.SectionPhysical
if isMapped {
totalMapRundownFiles.Add(1)
addr := e.Params.MustGetUint64(params.FileViewBase) + (e.Params.MustGetUint64(params.FileOffset))
e.AppendParam(params.FilePath, params.Path, f.getMappedFile(e.PID, addr))
}
}

return e, f.psnap.AddMmap(e)
Expand Down Expand Up @@ -179,17 +167,6 @@ func (f *fsProcessor) processEvent(e *event.Event) (*event.Event, error) {
// references fails, we search in the file handles for such file
fileinfo := f.findFile(fileKey, fileObject)

// try to resolve mapped file name if not found in internal state
if fileinfo == nil && e.IsMapViewFile() {
sec := e.Params.MustGetUint32(params.FileViewSectionType)
isMapped := sec != va.SectionPagefile && sec != va.SectionPhysical
if isMapped {
totalMapRundownFiles.Add(1)
addr := e.Params.MustGetUint64(params.FileViewBase) + (e.Params.MustGetUint64(params.FileOffset))
e.AppendParam(params.FilePath, params.Path, f.getMappedFile(e.PID, addr))
}
}

// ignore object misses that are produced by CloseFile
if fileinfo == nil && !e.IsCloseFile() {
fileObjectMisses.Add(1)
Expand Down Expand Up @@ -249,12 +226,3 @@ func (f *fsProcessor) findFile(fileKey, fileObject uint64) *FileInfo {
}
return nil
}

func (f *fsProcessor) getMappedFile(pid uint32, addr uint64) string {
process, err := windows.OpenProcess(windows.PROCESS_QUERY_INFORMATION, false, pid)
if err != nil {
return ""
}
defer windows.Close(process)
return fs.GetDevMapper().Convert(sys.GetMappedFile(process, uintptr(addr)))
}
Loading