Skip to content

Fix JSON-RPC error parsing in JacksonJsonRpcMapper - #2190

Merged
acogoluegnes merged 1 commit into
v5.xfrom
json-rpc-exception-fix
Nov 17, 2026
Merged

acogoluegnes merged 1 commit into
v5.xfrom
json-rpc-exception-fix

Conversation

@acogoluegnes

Copy link
Copy Markdown
Contributor

JacksonJsonRpcMapper's response parsing read the "error" field name instead of its value, so the JsonRpcException raised on the client side always had code 0 and a null message.

Also add tests for JsonRpcServer replying with a 400 error to requests it cannot parse (malformed JSON, nesting too deep, missing method, unknown procedure, wrong parameter count or type).

JacksonJsonRpcMapper's response parsing read the "error" field name
instead of its value, so the JsonRpcException raised on the client side
always had code 0 and a null message.

Also add tests for JsonRpcServer replying with a 400 error to requests
it cannot parse (malformed JSON, nesting too deep, missing method,
unknown procedure, wrong parameter count or type).
@acogoluegnes acogoluegnes added this to the 5.38.0 milestone Nov 17, 2026
@acogoluegnes
acogoluegnes marked this pull request as ready for review November 17, 2026 09:49
@acogoluegnes
acogoluegnes merged commit 716f524 into v5.x Nov 17, 2026
4 checks passed
@acogoluegnes
acogoluegnes deleted the json-rpc-exception-fix branch November 17, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant