Repository navigation
Reply with error to JSON-RPC requests the server cannot parse - #2189
Merged
Merged
Conversation
JsonRpcServer#doCall only caught ClassCastException, whereas JacksonJsonRpcMapper reports invalid requests (malformed JSON, nesting too deep, missing method, unknown procedure, wrong parameter count or type) with other runtime exceptions. Those escaped to RpcServer's main loop, which rejected the message without sending a reply, so the client waited until its timeout, forever by default. doCall now catches any RuntimeException and sends a 400 error response, as on 5.x. Also fix JacksonJsonRpcMapper's response parsing, which read the "error" field name instead of its value: the JsonRpcException raised on the client side always had code 0 and a null message.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JsonRpcServer#doCall only caught ClassCastException, whereas JacksonJsonRpcMapper reports invalid requests (malformed JSON, nesting too deep, missing method, unknown procedure, wrong parameter count or type) with other runtime exceptions. Those escaped to RpcServer's main loop, which rejected the message without sending a reply, so the client waited until its timeout, forever by default.
doCall now catches any RuntimeException and sends a 400 error response, as on 5.x.
Also fix JacksonJsonRpcMapper's response parsing, which read the "error" field name instead of its value: the JsonRpcException raised on the client side always had code 0 and a null message.