Conversation
krlmlr
force-pushed
the
claude/sembr
branch
from
September 13, 2026 20:41
d72fd9d to
a503a4a
Compare
krlmlr
added this pull request to stack #68
September 13, 2026 21:48
krlmlr
force-pushed
the
claude/sembr
branch
from
September 13, 2026 21:49
a503a4a to
c58542b
Compare
Reformatting only, no wording changes: prose in README.Rmd, the vignettes and the roxygen and inline comments under R/ now breaks at sentence and clause boundaries rather than wrapping to a fixed width. The payoff is sentence-level diffs. A reworded sentence touches one line instead of reflowing the paragraph around it, so review sees the change and not the rewrap. man/*.Rd is regenerated because roxygen2 passes source line breaks through to the .Rd. The rendered help is byte-identical -- checked with tools::Rd2txt() over every topic -- as is the rendered README. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WWhverMTZZKgEpUuTK117m
A sentence that spans more than one line, and the sentence after it, must each begin at the start of a line. The maintainer note at the top of README.Rmd was still wrapped to a fixed width, so two sentences started mid-line; README.md and index.md are re-rendered from it. Line breaks only, no wording changes. The note is the only offender the detector finds in this repository, and it carries no roxygen prose, so man/*.Rd is untouched and the rendered help is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WWhverMTZZKgEpUuTK117m
Continuation lines in roxygen paragraphs now carry two spaces after the comment marker instead of one, and the first line of a paragraph carries exactly one, so the source shows at a glance where a paragraph starts and where it merely continues. The rendered help is unchanged: this package enables markdown in roxygen2, which strips leading whitespace from continuation lines before the .Rd is written. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WWhverMTZZKgEpUuTK117m
The two-space continuation indent never reached the `.Rd`: this package sets `Roxygen: list(markdown = TRUE)`, and commonmark strips the leading whitespace of a continuation line before the help page is written. `man/` is unaffected by the indent either way. Reverting rather than substituting also restores the paragraph and tag alignment that the indent pass changed along the way. man/ is left to CI, which regenerates it from these sources. A line break which follows the end of a sentence currently renders as one space rather than two. Restoring that gap needs a patched roxygen2, which is a separate decision and a separate pull request, so it is deliberately not part of this change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01WWhverMTZZKgEpUuTK117m
krlmlr
force-pushed
the
claude/sembr
branch
from
September 14, 2026 05:58
c58542b to
3a8d31e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reformatting only, no wording changes. Prose in
README.Rmdand the roxygen and inline comments underR/now breaks at sentence and clause boundaries rather than wrapping to a fixed width.The payoff is sentence-level diffs. A reworded sentence touches one line instead of reflowing the paragraph around it, so review sees the change and not the rewrap.
R/import-standalone-purrr.Ris left alone — its header reads "Standalone file: do not edit by hand".Sentence pairs that the source separated with a double space are now broken apart like every other pair, so the convention holds throughout. Earlier revisions of this branch kept them joined on one line, because a break would have dropped the gap from the rendered help; that is no longer a reason to make an exception, for the reason in the next-but-one paragraph.
man/is not edited by hand in this pull request. The regenerated.Rdfiles are generated output, and CI roxygenises and commits them itself, so they arrive on this branch as an automated commit rather than in the hand-written diff.One consequence is worth stating plainly. A line break which follows the end of a sentence currently renders as one space, not two, so writing one sentence per line drops the sentence gap from the rendered help. Restoring it needs a patched roxygen2, which is a separate decision: it is krlmlr#4, stacked on top of this chain, and can be taken or left on its own. Without it this change simply renders as the package renders today.
This PR was missing from the chain. #61 already targeted this branch, but nothing represented the branch itself — so the goals PR sat on top of an unrepresented link. Found while auditing that every stacked PR targets its predecessor rather than
main.The branch was rebuilt on the
krlmlrfork while the work continued. Rather than force-pushing over the published history here, the rebuilt branch was brought in as a merge, so this branch only ever moved forward. The resulting tree is exactly the rebuilt one.Part of a fleet-wide pass. r-lib/here#195 is the reference PR, reviewed by hand before the rest were run.
🤖 Generated with Claude Code
https://claude.ai/code/session_01WWhverMTZZKgEpUuTK117m