[codex] add Benchling app config routing#394
Draft
drernie wants to merge 7 commits into
Draft
Conversation
- 01-config-issue.md — scope and goals for configurability - 02-bw-configurability.md — current configuration mechanisms - 03-benchling-config-sources.md — Benchling-native config via App Configuration Items + per-project routing Co-Authored-By: Claude <noreply@anthropic.com>
- 04-tier-audit.md — complete inventory of all 64 config parameters mapped to the three-tier model (App Config / Secrets / Env Vars) - 05-migration-strategy.md — phased rollout for both open-source standalone and platform-integrated deployments, covering legacy CfnParameter compatibility and rollback safety Co-Authored-By: Claude <noreply@anthropic.com>
…hecklist (#6) for #392 - 05a-list_app_configuration_items.md — procedure to determine the correct app_id parameter for list_app_configuration_items() - 06-configurability-checklist.md — revised with resolved P1/P2 issues: TTL caching, namespaced config:clear --force, app_id prerequisite, merge/precedence rules, folder-scoped project lookup, integrated-mode IAM guard Co-Authored-By: Claude <noreply@anthropic.com>
Address all findings from code review: - Move app-manifest.yaml schema to hard prerequisite (was Phase 5 docs) - Add cache-invalidation task for v2-beta.app.configuration.updated lifecycle events - Fix event type names to match actual app.py (v2.entry.* prefix) - Make config:seed schema-aware with cross-ref to prerequisite - Make config:clear conditional on SDK delete/archive support - Update namespace note to reflect SDK limitations Co-Authored-By: Claude <noreply@anthropic.com>
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config:inspect,config:seed, and manualconfig:clearhelpers, pluspackages.extraBucketsIAM support.0.19.0using the project npm version script.Validation
npm testNotes
config:seedstill requires the matching Benchling App Configuration schema paths to be defined indocker/app-manifest.yamland deployed before writes will succeed.config:clearintentionally lists items for manual cleanup because the current Benchling SDK has no usable delete/archive endpoint for App Configuration Items.