Repository navigation
Override tokio runtimes num threads via env vars - #6987
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
datadog-official
Bot
added
area:core
be26749 to
8e5ab75
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 53f4f9e429
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fn test_runtimes_config_default() { | ||
| let runtime_default = RuntimesConfig::default(); | ||
| fn test_runtimes_config_get() { | ||
| let runtime_default = RuntimesConfig::get(); |
There was a problem hiding this comment.
When either runtime override is set, this tests the environment-adjusted config as if it were the CPU-derived default. For example, QW_TOKIO_NON_BLOCKING_RUNTIME_NUM_THREADS=3 violates the next assertion, and a blocking override of 1 can violate the first. Since the overrides are supported independently, running the test suite with those settings makes this test fail.
Useful? React with 👍 / 👎.
guilload
changed the title
8e5ab75 to
5207209
Compare
No description provided.