Repository navigation
build(deps): bump sysinfo from 0.39.6 to 0.40.1 in /quickwit - #6973
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f4c78f3c2f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| syn = { version = "3.0", features = ["extra-traits", "full", "parsing"] } | ||
| sync_wrapper = "1" | ||
| sysinfo = { version = "0.39", default-features = false, features = ["disk"] } | ||
| sysinfo = { version = "0.40", default-features = false, features = ["disk"] } |
There was a problem hiding this comment.
Replace the removed
Disks::list API
With this version bump, sysinfo 0.40 removes Disks::list(), but quickwit-common/src/fs.rs still calls disks.list() in get_disk_size. Consequently, compiling quickwit-common fails with a missing-method error; update that iteration call as part of the dependency migration. The required post-manifest cargo check should cover this compatibility check.
AGENTS.md reference: AGENTS.md:L121-L121
Useful? React with 👍 / 👎.
f4c78f3 to
d3ebc30
Compare
Bumps [sysinfo](https://github.com/GuillaumeGomez/sysinfo) from 0.39.6 to 0.40.1. - [Changelog](https://github.com/GuillaumeGomez/sysinfo/blob/main/CHANGELOG.md) - [Commits](GuillaumeGomez/sysinfo@v0.39.6...v0.40.1) --- updated-dependencies: - dependency-name: sysinfo dependency-version: 0.40.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
d3ebc30 to
52c353c
Compare
Bumps sysinfo from 0.39.6 to 0.40.1.
Changelog
Sourced from sysinfo's changelog.
Commits
75dcd2cMerge pull request #1790 from GuillaumeGomez/update15a5e93Update crate version to0.40.14f252bdUpdate CHANGELOG for0.40.14a7b9e7Merge pull request #1789 from GuillaumeGomez/fromb19150aAdd backFrom\<X<Y>> for Vec\<Y>implementations forUsers,Groupsand `G...e27239aWindows: markSystem::load_averageas unsupported (#1788)70c58c7Fix wrong supported system list forGPUs13e94d5Windows: markSystem::load_averageas unsupported34677feallow getting ownedDiskfromDisks(#1786)48972c4Merge pull request #1784 from GuillaumeGomez/update