Repository navigation
build(deps): bump sea-query from 0.32.7 to 1.0.2 in /quickwit - #6971
dependabot[bot] wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a406b6d6f0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| rustls = "0.23" | ||
| rustls-pemfile = "2.2" | ||
| sea-query = { version = "0.32" } | ||
| sea-query = { version = "1.0" } |
There was a problem hiding this comment.
Upgrade the SQLx binder alongside SeaQuery
When quickwit-metastore/postgres is enabled—as it is in the CLI release feature sets—sea-query-binder 0.7.0 still resolves SeaQuery 0.32.7 while this dependency now supplies SeaQuery 1.0.2. Consequently, SqlxBinder is implemented for the 0.32 statement types rather than the 1.0 Query::select() types used by the metastore, so calls such as sql_query_builder.build_sqlx(PostgresQueryBuilder) no longer compile. Upgrade/migrate the binder to a version compatible with SeaQuery 1.0 as part of this bump.
AGENTS.md reference: AGENTS.md:L121-L121
Useful? React with 👍 / 👎.
| rustls = "0.23" | ||
| rustls-pemfile = "2.2" | ||
| sea-query = { version = "0.32" } | ||
| sea-query = { version = "1.0" } |
There was a problem hiding this comment.
Migrate metastore call sites to the SeaQuery 1.0 API
Even after selecting a compatible binder, enabling quickwit-metastore/postgres still fails to compile because this major-version bump was not accompanied by the required source migration: SeaQuery 1.0 moved operators such as .eq(), .gte(), and .not() from inherent methods to ExprTrait, but the PostgreSQL modules do not import that trait, and split_ids_to_array still constructs Value::String(Some(Box<String>)) although 1.0 expects Option<String>. Update these call sites as part of the version bump rather than only changing the manifest.
AGENTS.md reference: AGENTS.md:L121-L121
Useful? React with 👍 / 👎.
a406b6d to
dd96da7
Compare
Bumps [sea-query](https://github.com/SeaQL/sea-query) from 0.32.7 to 1.0.2. - [Release notes](https://github.com/SeaQL/sea-query/releases) - [Changelog](https://github.com/SeaQL/sea-query/blob/master/CHANGELOG.md) - [Commits](SeaQL/sea-query@0.32.7...1.0.2) --- updated-dependencies: - dependency-name: sea-query dependency-version: 1.0.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
dd96da7 to
28a6029
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Breezy! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Bumps sea-query from 0.32.7 to 1.0.2.
Changelog
Sourced from sea-query's changelog.
... (truncated)
Commits
f2d5e04Release SeaQuery 1.0.27920c04Fix 'Overriden' typo in commentd4d8cd4Use explicitSomepatterns insea_value_to_json_value(#1097)e4e46a9Fixsea_value_to_json_valueunexpectedly converting date/time value to "NULL".44db552feat: add clear_group_by() and clear_having() to SelectStatement (#1086)d6f100dAdd support for jiff types in sea-query-postgres24986a2Release sea-query-sqlx 0.9.14d15bc7Changelog3ab69b8releasecb9937brelease