Repository navigation
Shard scaling v2 feature flag - #6890
nadav-govari wants to merge 1 commit into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbecb309da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #[serde(default)] | ||
| enable_shard_scaling_v2: ConfigValue<bool, QW_ENABLE_SHARD_SCALING_V2>, |
There was a problem hiding this comment.
Document the new enable_shard_scaling_v2 property and QW_ENABLE_SHARD_SCALING_V2 override in the node-configuration reference. A repo-wide search shows that neither name appears outside the implementation and tests, so operators cannot discover the supported value, default, or rollout expectations for this newly exposed configuration.
AGENTS.md reference: AGENTS.md:L23-L24
Useful? React with 👍 / 👎.
| .into_iter() | ||
| .filter(|node| node.is_service_enabled(service)) | ||
| .collect(); | ||
| !service_nodes.is_empty() && service_nodes.iter().all(predicate) |
There was a problem hiding this comment.
Document that this helper returns false when no live node provides the requested service. That non-vacuous behavior differs from the usual semantics implied by all_*_satisfy, and callers using it as a rollout gate can otherwise wait indefinitely when the role is intentionally absent; the unit test records the behavior but does not expose this hidden API contract to callers.
AGENTS.md reference: AGENTS.md:L123-L126
Useful? React with 👍 / 👎.
This branch has not been deployed
1 participant
Description
Shard scaling v2 flag, gossiped, available as an env var. Helper that checks that the whole cluster has it enabled, which will be used to gate the features. Modeled after the compaction planner checker. Refactors the compaction planner checker to use a shared helper so that this type of logic is centralized.
How was this PR tested?
Unit tests.