Skip to content

feat: add built-in Arabic localization#14389

Open
ezAldinWaez wants to merge 2 commits intoquarto-dev:mainfrom
ezAldinWaez:feat/add-arabic-localization
Open

feat: add built-in Arabic localization#14389
ezAldinWaez wants to merge 2 commits intoquarto-dev:mainfrom
ezAldinWaez:feat/add-arabic-localization

Conversation

@ezAldinWaez
Copy link
Copy Markdown

@ezAldinWaez ezAldinWaez commented Apr 19, 2026

Description

This PR adds the built-in Arabic (ar) localization file following the BCP 47 IETF language tag standard.

Changes:

  1. Created src/resources/language/_language-ar.yml duplicating all keys from the _language.yml default.
  2. Verified exact key count parity (111 keys) with the English fallback to ensure flawless UI operations.
  3. Used standard formal Arabic Technical terms (MSA) for both scientific/manuscript contexts (e.g., references, appendices, footnotes) and programming/UI components (e.g., source code, listings, callouts etc.).
  4. Added _language-ar.yml directly to the supported language table in src/resources/language/README.md.

Testing

  • Locally rendered a .qmd sample file with lang: ar to ensure the correct application of key translations across callouts, categories, and cross-references.

Checklist

Copilot AI review requested due to automatic review settings April 19, 2026 06:13
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds built-in Arabic (ar) localization resources to Quarto’s bundled language pack, and documents Arabic as a supported built-in translation.

Changes:

  • Added src/resources/language/_language-ar.yml with Arabic translations for the default language keys.
  • Updated src/resources/language/README.md to include Arabic in the built-in translations table.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
src/resources/language/_language-ar.yml Introduces Arabic translations for Quarto UI/crossref strings.
src/resources/language/README.md Documents Arabic as a built-in localization option.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/resources/language/_language-ar.yml
Comment thread src/resources/language/_language-ar.yml
Comment thread src/resources/language/README.md
@cscheid
Copy link
Copy Markdown
Collaborator

cscheid commented Apr 20, 2026

Thanks for the PR. I would like to avoid LLM-generated localizations, and I get the sense that your PR was opened with LLM help, especially given the unrelated change to Korean:

image

Can you please review this manually before we go any further?

@ezAldinWaez
Copy link
Copy Markdown
Author

Can you please review this manually before we go any further?

honestly i did use some LLM help, but I did manually review every value in its context.

e.g: in Arabic, both 'الملاحق' and 'الملحقات' are acceptable translations for 'Appendices' (section-title-appendices), but 'الملاحق' is the most used in the academic context.

for the Korean change i'm not sure if it belongs here. happy to drop it if that’s cleaner.

@cscheid
Copy link
Copy Markdown
Collaborator

cscheid commented Apr 20, 2026

Yes, please either drop the Korean change or move it to a separate request.

For localization changes we try to get at least one independent review before merging. I'll get back to you on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants