fix: implement missing utilities and fix edge-case bugs - #278
Open
stooit wants to merge 1 commit into
Open
Conversation
- calculator: throw on division by zero instead of returning Infinity - string-utils: implement truncate (word-boundary, ellipsis counts toward maxLength, surrogate-pair safe) and fix wordCount for consecutive whitespace - task-manager: implement remove, update (partial), and sortBy (priority/createdAt) - date-utils: fix off-by-one in formatRelative (round instead of floor) - validator: allow long TLDs in isEmail and ports in isUrl All 60 tests pass; tsc --noEmit clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes all 16 previously-failing tests across the utility library. The full suite is now 60 pass / 0 fail, and
tsc --noEmitis clean. No test files were modified and no dependencies were added.Changes
src/calculator.ts—dividenow throws on a zero divisor instead of returningInfinity.src/string-utils.ts— implementedtruncate(cuts at a word boundary,"..."counts towardmaxLength, returns unchanged when it fits, UTF-16 surrogate-pair safe). FixedwordCountto split on/\s+/after trimming.src/task-manager.ts— implementedremove(false for unknown id),update(partial updates), andsortBy(priority high>medium>low;createdAtoldest first).src/date-utils.ts— fixed off-by-one informatRelative(Math.roundinstead ofMath.floor; 36h now reports "2 days ago").src/validator.ts—isEmailaccepts long TLDs (e.g.example.museum) and deeper subdomains while still rejecting empty labels;isUrlno longer rejects URLs with a port.Verification
bun test→ 60 pass, 0 failbunx tsc --noEmit→ cleanAssumptions / notes
dividethrowing on zero is a deliberate contract change for an exported function (test asserts it throws).update()uses the conventional partial-update pattern (!== undefined), so it cannot clear an optional field toundefined.truncatebehaviour formaxLength <= 3is a judgement call not pinned by tests.isEmail/isUrlremain pragmatic regex validators, not RFC-compliant.Reviewed by the review subagent; the one blocker raised (surrogate-pair splitting in
truncate) is fixed in this branch.