fix: repair 4 cross-package bugs and resolve type errors

apps/web/src/lib/api.ts

@@ -1,15 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
-import { formatDate, formatAUD } from "@e2e/utils"
+import { useDebounce, formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
 
@@ -28,5 +21,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook under the app-facing name
+export { useDebounce as useSearchDebounce }

packages/ui/src/components/Button/Button.tsx

@@ -14,16 +14,25 @@ type Props = {
   "aria-label"?: string
 }
 
+/**
+ * Neutral last-resort accessible name. Deliberately generic: guessing a
+ * purpose-specific label would mis-announce the control (e.g. calling a
+ * delete button "Add to favourites").
+ */
+const GENERIC_ICON_ONLY_LABEL = "Button"
+
+/** Labels already warned about, so the dev warning fires once per label. */
+const warnedLabels = new Set<string>()
+
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
- *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * Icon-only buttons render no visible text, so they must expose an accessible
+ * name via `aria-label` to satisfy WCAG 2.2 SC 4.1.2 (Name, Role, Value).
+ * An explicit `aria-label` is always used as given. When one is missing on an
+ * icon-only button we fall back to string `children`, else a generic label, so
+ * the control is never left unnamed — and warn in development, since only the
+ * author can supply a label that describes what the button actually does.
  */
 export function Button({
   children,
@@ -34,13 +43,23 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  const fallbackLabel = typeof children === "string" && children.trim() !== "" ? children : GENERIC_ICON_ONLY_LABEL
+  const accessibleLabel = ariaLabel ?? (iconOnly ? fallbackLabel : undefined)
+
+  if (iconOnly && !ariaLabel && process.env.NODE_ENV !== "production" && !warnedLabels.has(fallbackLabel)) {
+    warnedLabels.add(fallbackLabel)
+    console.warn(
+      "Button: `iconOnly` buttons require an `aria-label` describing the action (WCAG 2.2 SC 4.1.2). " +
+        `Falling back to "${fallbackLabel}".`,
+    )
+  }
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={accessibleLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}

packages/ui/src/components/DataTable/DataTable.tsx

@@ -16,22 +16,16 @@ type Props<T extends Record<string, unknown>> = {
 /**
  * DataTable with client-side sorting.
  *
- * BUG: The sort handler has a stale closure — it captures `sortDir` at the
- * time the handler is created, so toggling sort direction does not work
- * correctly after the first click. The second click always sorts in the same
- * direction as the first.
- *
- * Fix: use the functional form of setState — `setSortDir(prev => ...)` —
- * so the toggle always reads the current value.
+ * Clicking a sortable column sorts by it ascending; clicking the active column
+ * toggles between ascending and descending.
  */
 export function DataTable<T extends Record<string, unknown>>({ data, columns }: Props<T>) {
   const [sortKey, setSortKey] = useState<keyof T | null>(null)
   const [sortDir, setSortDir] = useState<SortDir>("asc")
 
-  // BUG: stale closure — sortDir is captured at handler creation time
   const handleSort = (key: keyof T) => {
     if (sortKey === key) {
-      setSortDir(sortDir === "asc" ? "desc" : "asc") // BUG: reads stale sortDir
+      setSortDir((prev) => (prev === "asc" ? "desc" : "asc"))
     } else {
       setSortKey(key)
       setSortDir("asc")

packages/utils/src/format/date.ts

@@ -1,21 +1,20 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * Dates are day-first (D/MM/YYYY) per `en-AU`, with the day's leading zero
+ * stripped. The fixed time zone keeps output deterministic across hosts.
  */
+const AU_DATE_FORMAT = new Intl.DateTimeFormat("en-AU", {
+  day: "numeric",
+  month: "2-digit",
+  year: "numeric",
+  timeZone: "Australia/Sydney",
+})
+
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
-    day: "numeric",
-    year: "numeric",
-  }).format(date)
+  return AU_DATE_FORMAT.formatToParts(date)
+    .map((part) => (part.type === "day" ? String(Number(part.value)) : part.value))
+    .join("")
 }
 
 export function formatDateTime(date: Date): string {

tsconfig.json

@@ -7,9 +7,21 @@
     "strict": true,
     "skipLibCheck": true,
     "paths": {
-      "@e2e/ui": ["./packages/ui/src/index.ts"],
-      "@e2e/utils": ["./packages/utils/src/index.ts"]
-    }
+      "@e2e/ui": [
+        "./packages/ui/src/index.ts"
+      ],
+      "@e2e/utils": [
+        "./packages/utils/src/index.ts"
+      ]
+    },
+    "types": [
+      "bun-types"
+    ]
   },
-  "include": ["packages/*/src/**/*", "packages/*/test/**/*", "apps/*/src/**/*"]
-}
+  "include": [
+    "packages/*/src/**/*",
+    "packages/*/test/**/*",
+    "apps/*/src/**/*",
+    "apps/*/test/**/*"
+  ]
+}