Repository navigation
BACKPORT: PCI: qcom: Set max OPP before icc enable during resume - #229
Open
Hariharan Sreedhar (hariharan-sree) wants to merge 1 commit into
Conversation
Hariharan Sreedhar (hariharan-sree)
requested review from
Bjordis Collaku (bjordiscollaku) and
Tingwei Zhang (quic-tingweiz)
as code owners
November 4, 2026 08:25
krishnachaitanya-linux
approved these changes
Nov 4, 2026
Hariharan Sreedhar (hariharan-sree)
force-pushed
the
pcie-resume-set-max-opp-fix
branch
from
November 5, 2026 09:50
e086162 to
d680769
Compare
krishnachaitanya-linux
approved these changes
Nov 10, 2026
During resume from D3cold, set the PCIe controller to the maximum OPP before enabling the ICC paths and accessing DBI registers. Without this, qcom_pcie_icc_opp_update() may access DBI before OPP votes are restored, triggering NoC errors. Signed-off-by: Hariharan Sreedhar <hariharan.sreedhar@oss.qualcomm.com> Link: https://lore.kernel.org/all/20260416-setmaxopp-v1-1-6a74e2d945a0@oss.qualcomm.com/
Hariharan Sreedhar (hariharan-sree)
force-pushed
the
pcie-resume-set-max-opp-fix
branch
from
November 10, 2026 03:58
d680769 to
60b6940
Compare
Hariharan Sreedhar (hariharan-sree)
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During resume from D3cold, set the PCIe controller to the maximum OPP before enabling the ICC paths and accessing DBI registers. Without this, qcom_pcie_icc_opp_update() may access DBI before OPP votes are restored, triggering NoC errors.
Link: https://lore.kernel.org/all/20260416-setmaxopp-v1-1-6a74e2d945a0@oss.qualcomm.com/