add selectable Camera_NHX configs for CAMX validation#435
Open
smuppand wants to merge 5 commits intoqualcomm-linux:mainfrom
Open
add selectable Camera_NHX configs for CAMX validation#435smuppand wants to merge 5 commits intoqualcomm-linux:mainfrom
smuppand wants to merge 5 commits intoqualcomm-linux:mainfrom
Conversation
Update Runner/suites/Multimedia/Camera/Camera_NHX/run.sh to improve cam-server handling and post-run reporting around NHX execution. Changes in this update: - stop cam-server only when the service is actually active - avoid misleading stop/start log messages when cam-server is already inactive or restart is not needed - log post-NHX cam-server actions as start attempts and verify active state separately - skip dump validation when nhx.sh exits early - avoid appending dump-related failure reasons when NHX already failed before dumps were expected Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Add nhx_resolve_json_file() to resolve NHX JSON configs from an absolute path, Camera_NHX-relative path, or target-specific folder. The helper supports Kodiak, Lemans, Monaco, and Talos config layouts and returns a distinct status when a basename matches multiple target folders, allowing run.sh to request --target for disambiguation. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Extend Camera_NHX to accept --json and --target arguments, while keeping the existing default nhx.sh behavior unchanged when no JSON is provided. The test now resolves the requested JSON through lib_camera.sh and passes the selected config to nhx.sh, enabling preview, video, preview+video, and snapshot validation through LAVA or manual CLI without auto-running all available JSON files. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Add NHX JSON configs for supported camera validation scenarios across Kodiak, Lemans, Monaco, and Talos. The configs enable targeted execution of preview, video, preview+video, and snapshot scenarios through Camera_NHX --json/--target selection. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Update Camera_NHX README with the new --json/--target usage, target-specific NHX JSON layout, and nhx.sh staging behavior under /etc/camera/test/NHX. Document default behavior, manual and LAVA invocation examples, supported targets, output summary fields, and troubleshooting notes for selected NHX configs. Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends Camera_NHX so CAMX validation can run selected NHX scenarios instead of only the default preview flow.
It adds target-specific NHX JSON configs for Kodiak, Lemans, Monaco, and Talos, adds --json/--target support in Camera_NHX, stages selected configs under /etc/camera/test/NHX as required by nhx.sh, and updates CAMX DT matching to recognize current camera overlay compatibles.
Default behavior remains unchanged when no JSON is passed, while LAVA/manual runs can now explicitly validate preview, video, preview+video, and snapshot flows.