Skip to content

fix: extend WiFi firmware validation for ath12k platforms#423

Merged
bhargav0610 merged 2 commits intoqualcomm-linux:mainfrom
smuppand:wifi-connectivity
Apr 24, 2026
Merged

fix: extend WiFi firmware validation for ath12k platforms#423
bhargav0610 merged 2 commits intoqualcomm-linux:mainfrom
smuppand:wifi-connectivity

Conversation

@smuppand
Copy link
Copy Markdown
Contributor

This PR fixes #418 and improves WiFi_Firmware_Driver coverage and reuses shared WiFi connectivity helpers from lib_connectivity.sh.

Changes included:

  • add shared WiFi firmware helpers in lib_connectivity.sh for:
    • firmware family detection
    • ath12k, ath11k, and ath10k runtime handling
    • family-specific module visibility checks
    • firmware load/use evidence checks
    • tagged WiFi probe/runtime failure reporting
  • extend WiFi_Firmware_Driver to support ath12k/WCN7850 firmware layouts, including Glymur platforms with firmware under /lib/firmware/ath12k/WCN7850
  • preserve existing ath11k and ath10k validation behavior
  • reuse the common WiFi probe failure checker already used by WiFi_OnOff
  • improve stdout readability with firmware/probe tags and generated dmesg artifacts

Why:

  • the existing test only handled ath11k and ath10k firmware layouts
  • Glymur uses ath12k/WCN7850 with ath12k_wifi7 and ath12k modules
  • firmware presence alone was not enough; the test now also validates module visibility, firmware load/use evidence, and probe/runtime failures
  • shared helpers avoid duplicating WiFi family logic across WiFi tests.

The Glymur lava instance is currently unavailable for reference. Therefore, the target was executed, and the following information is provided as a reference.

 /Runner/suites/Connectivity/WiFi/WiFi_Firmware_Driver# ./run.sh
[INFO] 2026-04-24 09:10:27 - --------------------------------------------------------------------------
[INFO] 2026-04-24 09:10:27 - -------------------Starting WiFi_Firmware_Driver Testcase----------------------------
[INFO] 2026-04-24 09:10:27 - === Test Initialization ===
[INFO] 2026-04-24 09:10:27 - Probe log tag: WiFi_Firmware_Driver/probe
[INFO] 2026-04-24 09:10:27 - Firmware log tag: WiFi_Firmware_Driver/firmware
[INFO] 2026-04-24 09:10:27 - Detected SoC model: Qualcomm Technologies, Inc. Glymur CRD
[INFO] 2026-04-24 09:10:27 - === WiFi Firmware Detection ===
[INFO] 2026-04-24 09:10:27 - Detected WiFi firmware family: ath12k
[INFO] 2026-04-24 09:10:27 - Detected firmware [amss.bin]: /lib/firmware/ath12k/WCN7850/hw2.0/ncm865/amss.bin (size: 6111296 bytes)
[INFO] 2026-04-24 09:10:27 - === Family-specific Runtime Preparation ===
[INFO] 2026-04-24 09:10:27 - ath12k firmware detected, handling WCN7850 / Wi-Fi 7 class platform.
[INFO] 2026-04-24 09:10:27 - Module already loaded: ath12k_wifi7
[INFO] 2026-04-24 09:10:27 - === Family-specific Module Visibility ===
[INFO] 2026-04-24 09:10:27 - Checking active ath12k-related kernel modules.
[PASS] 2026-04-24 09:10:27 - Module loaded: ath12k_wifi7
[INFO] 2026-04-24 09:10:27 - [module-path] ath12k_wifi7 -> /lib/modules/7.0.0-rc6-00633-gaa085abae3ad/kernel/drivers/net/wireless/ath/ath12k/wifi7/ath12k_wifi7.ko
[PASS] 2026-04-24 09:10:27 - Module loaded: ath12k
[INFO] 2026-04-24 09:10:27 - [module-path] ath12k -> /lib/modules/7.0.0-rc6-00633-gaa085abae3ad/kernel/drivers/net/wireless/ath/ath12k/ath12k.ko
[INFO] 2026-04-24 09:10:27 - Module not loaded: ath12k_pci
[INFO] 2026-04-24 09:10:27 - [module-path] ath12k_pci -> not found
[INFO] 2026-04-24 09:10:27 - Module not loaded: ath12k_ahb
[INFO] 2026-04-24 09:10:27 - [module-path] ath12k_ahb -> not found
[PASS] 2026-04-24 09:10:27 - Module loaded: cfg80211
[INFO] 2026-04-24 09:10:27 - [module-path] cfg80211 -> /lib/modules/7.0.0-rc6-00633-gaa085abae3ad/kernel/net/wireless/cfg80211.ko
[PASS] 2026-04-24 09:10:27 - Module loaded: mac80211
[INFO] 2026-04-24 09:10:27 - [module-path] mac80211 -> /lib/modules/7.0.0-rc6-00633-gaa085abae3ad/kernel/net/mac80211/mac80211.ko
[PASS] 2026-04-24 09:10:27 - Module loaded: mhi
[INFO] 2026-04-24 09:10:27 - [module-path] mhi -> /lib/modules/7.0.0-rc6-00633-gaa085abae3ad/kernel/drivers/bus/mhi/host/mhi.ko
[INFO] 2026-04-24 09:10:27 - === WiFi Firmware Load Evidence ===
[INFO] 2026-04-24 09:10:27 - [WiFi_Firmware_Driver/firmware] Jan 01 00:00:29 glymur-crd kernel: ath12k_wifi7_pci 0004:01:00.0: BAR 0 [mem 0x78400000-0x785fffff 64bit]: assigned
[INFO] 2026-04-24 09:10:27 - [WiFi_Firmware_Driver/firmware] Jan 01 00:00:29 glymur-crd kernel: ath12k_wifi7_pci 0004:01:00.0: enabling device (0000 -> 0002)
[INFO] 2026-04-24 09:10:27 - [WiFi_Firmware_Driver/firmware] Jan 01 00:00:29 glymur-crd kernel: ath12k_wifi7_pci 0004:01:00.0: Wi-Fi 7 Hardware name: wcn7850 hw2.0
[INFO] 2026-04-24 09:10:27 - [WiFi_Firmware_Driver/firmware] Jan 01 00:00:29 glymur-crd kernel: ath12k_wifi7_pci 0004:01:00.0: MSI vectors: 16
[INFO] 2026-04-24 09:10:27 - [WiFi_Firmware_Driver/firmware] Jan 01 00:00:29 glymur-crd kernel: ath12k_wifi7_pci 0004:01:00.0: chip_id 0x2 chip_family 0x4 board_id 0x10f soc_id 0x40170200
[INFO] 2026-04-24 09:10:27 - [WiFi_Firmware_Driver/firmware] Jan 01 00:00:29 glymur-crd kernel: ath12k_wifi7_pci 0004:01:00.0: fw_version 0x110cffff fw_build_timestamp 2025-06-25 09:26 fw_build_id QC_IMAGE_VERSION_STRING=WLAN.HMT.1.1.c5-00302-QCAHMTSWPL_V1.0_V2.0_SILICONZ-1.115823.3
[INFO] 2026-04-24 09:10:27 - [WiFi_Firmware_Driver/firmware] Jan 01 00:00:29 glymur-crd kernel: ath12k_wifi7_pci 0004:01:00.0 wlP4p1s0: renamed from wlan0
[INFO] 2026-04-24 09:10:27 - [WiFi_Firmware_Driver/firmware] Jan 01 00:00:31 glymur-crd kernel: Modules linked in: mhi_net mhi_wwan_ctrl wwan gnss usb_f_fs libcomposite snd_q6apm(+) apr panel_samsung_atna33xc20 qrtr_mhi rpmsg_ctrl fastrpc rpmsg_char qrtr_smd qcom_pd_mapper msm ubwc_config ath12k_wifi7 ocmem snd_soc_x1e80100 ath12k qcom_q6v5_pas gpu_sched snd_soc_lpass_wsa_macro snd_soc_lpass_va_macro snd_soc_qcom_sdw hid_multitouch pmic_glink_altmode ucsi_glink mac80211 soundwire_qcom snd_soc_qcom_common drm_gpuvm snd_soc_lpass_macro_common qcom_pil_info qcom_battmgr typec_ucsi aux_hpd_bridge phy_qcom_edp sm3_ce phy_qcom_eusb2_repeater phy_qcom_qmp_combo snd_soc_core qcom_q6v5 libarc4 drm_exec qcom_spmi_temp_alarm qcom_pon rtc_pm8xxx nvmem_qcom_spmi_sdam qcom_stats drm_display_helper stm_p_basic coresight_stm snd_compress i2c_hid_of sha256 phy_nxp_ptn3222 dwc3_qcom snd_pcm qcom_sysmon cec aux_bridge i2c_hid stm_core dispcc_glymur videocc_glymur coresight_cti coresight_tpdm qcom_eud typec cfg80211 soundwire_bus snd_timer pinctrl_sm8650_lpass_lpi qcom_common drm_dp_aux_bus phy_qcom_m31_eusb2 gpi
[PASS] 2026-04-24 09:10:27 - [WiFi_Firmware_Driver/firmware] Firmware load/use evidence found.
[INFO] 2026-04-24 09:10:27 - === WiFi Probe Check ===
[PASS] 2026-04-24 09:10:27 - [WiFi_Firmware_Driver/probe] No WiFi probe/runtime failures detected in kernel log.
[PASS] 2026-04-24 09:10:27 - WiFi_Firmware_Driver: PASS - WiFi firmware and driver validation successful.

@smuppand smuppand requested a review from bhargav0610 April 24, 2026 10:45
Add reusable connectivity helpers for WiFi firmware detection, family-specific
runtime handling, module visibility checks, firmware load evidence, and tagged
probe-failure reporting.

The new helpers support ath12k, ath11k, and ath10k based platforms, including
Glymur/WCN7850 ath12k firmware layouts, while reusing existing functestlib
helpers for module lookup, module state, dmesg scanning, and remoteproc checks.

Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
Refactor WiFi_Firmware_Driver to use shared lib_connectivity helpers for
firmware detection, family-specific driver handling, module validation,
firmware load evidence, and probe-failure checks.

This extends coverage to ath12k/WCN7850 platforms such as Glymur while
preserving existing ath11k and ath10k validation flow. The test now reports
clear stdout tags for firmware evidence and probe checks, generates dmesg
artifacts, and keeps PASS/FAIL/SKIP decisions based on the full validation
summary.

Signed-off-by: Srikanth Muppandam <smuppand@qti.qualcomm.com>
@smuppand smuppand force-pushed the wifi-connectivity branch from 0c1016a to 4e6df0e Compare April 24, 2026 10:59
@bhargav0610 bhargav0610 merged commit 820fdc2 into qualcomm-linux:main Apr 24, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Glymur LE: Wi-FI firmware_driver Test failure

2 participants