GStreamer imsdk camera test suite#405
Conversation
5638a88 to
54e7f3b
Compare
There was a problem hiding this comment.
This PR would be much easier to review and maintain if it is reduced to the minimum supported feature set.
Right now the suite is over-expanded for an initial submission: the runner is very large, the README is very long, and the shared library change includes helper additions that do not appear to be required by the suite’s current execution path.
Please tighten this PR. Suggested cleanup:
-
Remove interfaces that are not actually implemented end-to-end yet
- e.g.
--test-name/CAMERA_TEST_NAMEif single-test filtering is not wired up - remove snapshot-related helper additions if snapshot tests are not actually executed
- e.g.
-
Keep only shared
lib_gstreamer.shhelpers that are used by this suite today -
Reduce the README to the essentials
- overview
- prerequisites
- actual supported test matrix
- parameters
- basic troubleshooting
-
Split into 2 commits
- shared helper additions
- Camera_Tests suite files
-
Fix the YAML wrapper to the repo-standard form while respinning
If needed, it would also be reasonable to reduce this to a smaller MVP first (for example only the verified backend/test paths), and then add more coverage in follow-up PRs.
|
smuppand
left a comment
There was a problem hiding this comment.
Please squash the commits into
At most, 2 logical commits would make sense:
- shared
Runner/utils/[lib_gstreamer.sh](http://lib_gstreamer.sh/)helper additions Camera_Testssuite files
72274d8 to
e6e24b7
Compare
|
quashed commits as suggested.
Please review. Thanks! |
ff80587 to
35f4a80
Compare
smuppand
left a comment
There was a problem hiding this comment.
The PR is much closer now, and I no longer see the previous major structural blockers. Only minor comment fixes and the main shell lint issues remain.
adecc41 to
99ff31a
Compare
0bffdac to
7536960
Compare
|
To get the camera working, we need to load the cdt first. This support is not available on LAVA yet; the scripts have been locally tested and validated already. |
we are loading CDT for rb3gen2 |
Could you indicate which lava job is running the camera tests? |
sorry missed earlier to place the lava job and here is the lava job where we ran on next branch and waiting for these changes to consume in meta-qcom https://lava.infra.foundries.io/scheduler/job/181041#L205 |
e021a23 to
7f664b5
Compare
|
I’ve rebased the branch onto the latest main, cleaned up the history, and force‑pushed with two focused commits. Please take another look. |
Please resolve conflicts |
|
resolved. |
|
Tried on rb8, with has-camera tag enabled. I see same errors for both |
@bhargav0610, could you please confirm whether the camera sensors are connected to the RB8 devices? @nitinn22, could you try using RB3GEn2, where the camera will be installed beforehand? |
|
@nitinn22 please address the execute permission issues for the run.sh https://github.com/qualcomm-linux/qcom-linux-testkit/actions/runs/24783804921/job/72824221798?pr=405 |
|
Fixed exec permissions on run.sh |
|
@nitinn22 Functionally this looks good to merge. Only minor non-blocking notes remain:
|
d01d77f to
27095aa
Compare
|
Resolved all items. |
331fc36 to
ed90e86
Compare
|
@nitinn22 There are still merge conflicts. Could you please resolve them? |
ed90e86 to
a82ce9d
Compare
Signed-off-by: nitinn <nitinn@qti.qualcomm.com>
a82ce9d to
84edd1e
Compare
Signed-off-by: nitinn <nitinn@qti.qualcomm.com>
84edd1e to
6c720a1
Compare
Resolved conflicts. |
This test suite provides comprehensive validation of camera functionality using GStreamer with Qualcomm's qtiqmmfsrc plugin (downstream) or libcamerasrc (upstream). Tests run in a specific sequence to validate different camera capabilities progressively.
The test suite automatically detects which camera source plugin is available:
qtiqmmfsrc (Qualcomm CAMX downstream): Runs 10 tests
libcamerasrc (upstream): Runs 7 tests
Lava job for reference with these changes, Refer https://lava.infra.foundries.io/scheduler/job/182439#L2523