Skip to content

fix: keep SSO library classes and generic signatures in release builds #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pbek merged 1 commit into from
Sep 17, 2026
Merged

fix: keep SSO library classes and generic signatures in release builds #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions app/proguard-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,18 @@
# The Nextcloud SSO library's NextcloudRetrofitServiceMethod inspects generic return types
# reflectively (method.getGenericReturnType()) to decide how to deserialize responses. Without
# this attribute R8 erases that generic signature, the type check silently falls back to a
# different code path, and every SSO-relayed request breaks in release builds only.
-keepattributes Signature

# Android-SingleSignOn 1.3.4 ships consumer proguard rules of its own (including the
# -keepattributes Signature above), but they don't keep NextcloudRetrofitServiceMethod or
# ParsedResponse themselves, so R8 full mode is still free to rename/optimize them — which
# corrupts the nested generic Signature (Observable<ParsedResponse<OcsResponse>> loses its
# inner <OcsResponse> argument) when it remaps the Signature attribute string. Keep just the
# two classes proven necessary rather than the whole com.nextcloud.android.sso namespace.
-keep class com.nextcloud.android.sso.api.NextcloudRetrofitServiceMethod { *; }
-keep class com.nextcloud.android.sso.api.ParsedResponse { *; }

# Retrofit and Gson access Nextcloud API contracts and payloads reflectively.
-keep,allowoptimization interface org.qownnotes.mobile.backend.nextcloud.**Api { *; }
-keep,allowoptimization class org.qownnotes.mobile.backend.nextcloud.**Dto { *; }
Expand Down
Loading