Skip to content

Upgrade Sandwich SDK to 7.13.1 - #333

Merged
SpertsyanKM merged 1 commit into
mainfrom
kamo/dev-1837-sdk-iosandroid-ubrat-trust-all-tls-otklyuchennaya-proverka
Sep 18, 2026
Merged

SpertsyanKM merged 1 commit into
mainfrom
kamo/dev-1837-sdk-iosandroid-ubrat-trust-all-tls-otklyuchennaya-proverka

Conversation

@SpertsyanKM

@SpertsyanKM SpertsyanKM commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Bumps the Sandwich SDK pin to 7.13.1, which carries the native Qonversion SDKs with restored TLS certificate validation (iOS 6.17.2, Android sdk 9.7.1, No-Codes 1.11.1). The commit is the one produced by the Upgrade Sandwich cascade, cherry-picked into a regular branch so the one-click release.yml flow can be used afterwards.

Linear: DEV-1837

🤖 Generated with Claude Code

https://claude.ai/code/session_01LaLgoRfHyEeVXkmkrwkWip

Summary by CodeRabbit

  • Chores
    • Updated the Qonversion Sandwich dependency to version 7.13.1 across Android, Swift Package Manager, and iOS integrations.

(cherry picked from commit c2e8c46)
@coderabbitai

coderabbitai Bot commented Sep 18, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: qonversion/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: a66b5e16-f79c-4bf1-8f4d-2512fba181da

📥 Commits

Reviewing files that changed from the base of the PR and between 957b834 and 113197b.

📒 Files selected for processing (1)
  • Editor/QonversionDependencies.xml
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • qonversion/go-micro (manual)

Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour.


📝 Walkthrough

Walkthrough

The pull request updates the Sandwich dependency from version 7.13.0 to 7.13.1 for Android, Swift Package Manager, and iOS pod integrations.

Changes

Sandwich dependency update

Layer / File(s) Summary
Update dependency declarations
Editor/QonversionDependencies.xml
The Android package, remote Swift package, and iOS pod declarations now use Sandwich version 7.13.1.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 11319

This dependency-only update has no identified merge-blocking impact.


Caution

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

  • Ignore (reviewers only)

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Behavior And Regression Safety ❌ Error The Android pin introduces a concrete dependency-resolution failure. The changed Editor/QonversionDependencies.xml:4 makes EDM4U resolve io.qonversion:sandwich:7.13.1. Maven Central has `io.qonver… Publish io.qonversion:sandwich:7.13.1 to a repository used by EDM4U before merging this pin, or configure and declare the repository that already contains it. Then verify that the exact POM/AAR resolves. Do not merge the current Android p…
✅ Passed checks (7 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title identifies the affected product, the Sandwich SDK, and states the outcome, upgrading it to version 7.13.1.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Security And Tenant Isolation ✅ Passed PASS. The PR changes only three dependency version pins in Editor/QonversionDependencies.xml, from 7.13.0 to 7.13.1. The Android, Swift package, and iOS pod pins remain equal, and XML validation plus …
Contract And Data Compatibility ✅ Passed The pull request changes only Editor/QonversionDependencies.xml. It changes the Sandwich pin from 7.13.0 to 7.13.1 in the Android package, Swift package, and iOS pod fallback. The pins remain consis…
Rollout And Recovery Evidence ✅ Passed PASS. The pull request changes only three Sandwich dependency pins in Editor/QonversionDependencies.xml; it does not change release, deployment, or infrastructure controls. The XML parses successful…
Full details: Behavior And Regression Safety

Explanation

The Android pin introduces a concrete dependency-resolution failure. The changed Editor/QonversionDependencies.xml:4 makes EDM4U resolve io.qonversion:sandwich:7.13.1. Maven Central has io.qonversion:sandwich only through 7.13.0; both Maven Central endpoints return 404 for the 7.13.1 POM. The repository contains no alternate Maven repository declaration or bundled Android artifact. The upstream 7.13.1 tag and iOS CocoaPod exist, but the release has no assets, so the Android build cannot resolve the new coordinate.

Resolution

Publish io.qonversion:sandwich:7.13.1 to a repository used by EDM4U before merging this pin, or configure and declare the repository that already contains it. Then verify that the exact POM/AAR resolves. Do not merge the current Android pin while the coordinate returns 404.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pre-merge checks failed. Please resolve the failing checks before merging.

@SpertsyanKM
SpertsyanKM merged commit e946226 into main Sep 18, 2026
2 checks passed
@SpertsyanKM
SpertsyanKM deleted the kamo/dev-1837-sdk-iosandroid-ubrat-trust-all-tls-otklyuchennaya-proverka branch September 18, 2026 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant