Release 9.10.0 - #330
Release 9.10.0#330
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: qonversion/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: 8 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. 📝 WalkthroughWalkthroughThe package metadata and internal Unity SDK version reported to native wrappers are updated from ChangesSDK Version Alignment
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Feature Merge Risk: ⚪ Minimal · up to This version-alignment change presents no identified merge-blocking risk. Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (1 error, 3 warnings)
✅ Passed checks (4 passed)
Full details: Title checkExplanation The title identifies the release version but does not name the affected product or system area, or the behavioral outcome. The changes affect the Unity SDK and add or update release integration behavior. Full details: Linked Issues checkExplanation Issue Resolution Implement the SPM-compatible iOS bridge and dependency configuration for the Unity package. Retain the CocoaPods path where required. Add automated coverage that verifies an SPM-based Unity iOS build and the bridge types used by the project. Full details: Out of Scope Changes checkExplanation The reviewed changes update only the Unity SDK version from Full details: Rollout And Recovery EvidenceExplanation This release PR activates an automatic public release path without bounded rollout evidence. The reviewed diff changes the package version and the runtime-reported SDK version to 9.10.0. GitHub identifies the head as Resolution Before merge, add a release plan and enforce it as a merge gate. Define concrete verification results for the 9.10.0 artifact, including the supported Unity/iOS SPM, CocoaPods fallback, and Android paths. Define the activation order from merge to tag/GitHub release and package availability. Define stop signals and who can stop or disable the release workflow before publication. Define recovery for a bad release, including retaining the prior version for consumers, avoiding tag reuse, and issuing a forward-fix version. Do not merge while the
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Release PR
New
Editor/QonversionDependencies.xmlnow declares the nativeQonversionSandwichas a Swift package (https://github.com/qonversion/sandwich-sdk.git, exact7.13.0) next to the CocoaPod. With External Dependency Manager for Unity (EDM4U) 1.2.189+ on Unity 2021.3+ and Swift Package Manager Integration enabled inAssets → External Dependency Manager → iOS Resolver → Settings(the default), the package is linked intoUnityFrameworkand the pod is left out of the generated Podfile — no action needed. Older EDM4U, Unity older than 2021.3 or SPM integration turned off keep installing theQonversionSandwichCocoaPod exactly as before. Resolves Unity SDK not compatible with new qonversion-ios-sdk (SPM) – QonversionSandwich module missing qonversion-ios-sdk#643 (Swift Package Manager support for iOS via EDM4U (CocoaPods kept as fallback), sandwich 7.13.0 #329).Improvements & fixes
PromotionalOffer(productDiscount:paymentDiscount:)initializer,QONErrors.isAuthorizationError, fixed Swift Package Manager build for tvOS. Android stays on 9.7.0 (Swift Package Manager support for iOS via EDM4U (CocoaPods kept as fallback), sandwich 7.13.0 #329).Breaking notes & requirements
com.google.external-dependency-managerfrom OpenUPM or the.unitypackagefrom EDM4U's GitHub releases — Google's UPM registry is no longer available), Xcode 15+, iOS deployment target 13.0+ (unchanged), github.com reachable from the build machine. To stay on CocoaPods, turn off Swift Package Manager Integration in the iOS Resolver settings.Qonversionpod in your own*Dependencies.xmlor Podfile, or aqonversion-ios-sdkSwift package (for example as a workaround for ios#643) — remove it: the sandwich package depends onqonversion-ios-sdkexactly 6.15.0, a second copy produces duplicate symbols or a package resolution conflict. On the CocoaPods path the previous rule still applies: apps that also declare theQonversionpod must move to 6.15.0.pod installstill runs, so CocoaPods must still be installed andUnity-iPhone.xcworkspaceis still produced. If Qonversion is your only pod, turn off Allow empty Podfile generation in the iOS Resolver settings to skip CocoaPods entirely — then open and buildUnity-iPhone.xcodeprojinstead of the workspace.QonversionSandwichCocoaPod remains available as a fallback, but plan to move to the Swift Package Manager path before then.Summary by CodeRabbit