Upgrade Sandwich SDK to 7.13.1 - #465
SpertsyanKM merged 1 commit into
Conversation
(cherry picked from commit fe43aeb)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: qonversion/coderabbit/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 8 reviews per hour. 📝 WalkthroughWalkthroughThe native Android and iOS configurations update their Sandwich dependency from version 7.12.0 to 7.13.1. ChangesSandwich dependency update
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Merge Risk: ⚪ Minimal · up to The requested Sandwich upgrade is consistently applied across both native platforms, with no evidenced merge-blocking risk. Caution Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional.
❌ Failed checks (2 errors)
✅ Passed checks (6 passed)
Full details: Behavior And Regression SafetyExplanation The Android dependency change introduces an unresolved artifact. Resolution Publish Full details: Rollout And Recovery EvidenceExplanation The change affects production runtime behavior. The two changed pins make Android and iOS consumers resolve Sandwich/QonversionSandwich 7.13.1, and the PR states that this restores TLS certificate validation in the native SDKs. The PR description provides no concrete verification, activation gates or order, stop signals, rollback, or forward-recovery instructions. The repository has a release/publish path, including a conditional merge-triggered publish workflow, but the PR only says that the release flow will be used afterwards. It does not bound the activation or recovery of this behavior. Resolution Add a rollout record before merge. Include Android, iOS, and No-Codes verification for valid and invalid TLS certificates, plus package build and dependency-resolution checks. Define the activation order from merge to release, package publication, and downstream application release. Define stop signals and thresholds for TLS failures, initialization failures, purchase or entitlement failures, and crash regressions. Document a rollback by reverting both pins to 7.12.0 and publishing a higher package version, or document a tested forward-recovery procedure.
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Bumps the Sandwich SDK pin to 7.13.1, which carries the native Qonversion SDKs with restored TLS certificate validation (iOS 6.17.2, Android sdk 9.7.1, No-Codes 1.11.1). The commit is the one produced by the
Upgrade Sandwichcascade, cherry-picked into a regular branch so the one-clickrelease.ymlflow can be used afterwards.Linear: DEV-1837
🤖 Generated with Claude Code
https://claude.ai/code/session_01LaLgoRfHyEeVXkmkrwkWip
Summary by CodeRabbit