Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Sources/SwiftJavaToolLib/JavaClassTranslator.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1175,7 +1175,7 @@ extension JavaClassTranslator {

let resultOptional: String = resultType.optionalWrappedType() ?? resultType
let baseBody: ExprSyntax =
"\(raw: javaMethod.throwsCheckedException ? "try " : "")\(raw: swiftMethodName)(\(raw: parameters.map(\.passedArg).joined(separator: ", ")))"
"\(raw: javaMethod.throwsCheckedException ? "try " : "")self.\(raw: swiftMethodName)(\(raw: parameters.map(\.passedArg).joined(separator: ", ")))"
let body: ExprSyntax =
if resultType.optionalWrappedType() != nil {
"Optional(javaOptional: \(baseBody))"
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2025 Apple Inc. and the Swift.org project authors
// Licensed under Apache License v2.0
//
// See LICENSE.txt for license information
// See CONTRIBUTORS.txt for the list of Swift.org project authors
//
// SPDX-License-Identifier: Apache-2.0
//
//===----------------------------------------------------------------------===//

import XCTest

final class OptionalMethodWrapJavaTests: XCTestCase {
func testOptionalConveniencesQualifyTheOriginalMethod() async throws {
let classpath = try await compileJava(
"""
package com.example;
class OptionalMethodCollision {
public java.util.OptionalLong arg0(java.util.OptionalLong value) { return value; }
public java.util.OptionalLong checked(java.util.OptionalLong value) throws java.io.IOException { return value; }
public static java.util.OptionalLong staticValue(java.util.OptionalLong value) { return value; }
public long accept(java.util.OptionalLong value) { return value.orElse(0); }
}
"""
)
try assertWrapJavaOutput(
javaClassNames: ["java.util.OptionalLong", "com.example.OptionalMethodCollision"],
classNameMappings: ["java.util.OptionalLong": "JavaOptionalLong"],
classpath: [classpath],
expectedChunks: [
"Optional(javaOptional: self.arg0(arg0.toJavaOptional()))",
"Optional(javaOptional: try self.checked(arg0.toJavaOptional()))",
"Optional(javaOptional: self.staticValue(arg0.toJavaOptional()))",
"self.accept(arg0.toJavaOptional())",
]
)
}
}
Loading