fix(layout): respect native maximum window heights - #114
Conversation
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused, well-scoped fix to native window-size handling, with additive state propagation and targeted lifecycle/layout regression coverage. Its runtime effect is limited to discarding stale compact sizing for windows without a current native height bound while preserving existing width behavior. You can add or adjust custom eligibility rules. Learn more. |
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Summary
Dia could retain a temporarily short native frame instead of filling its tile. Only windows with a current native maximum height may retain accepted compact sizes, preserving Device Hub previews.
Height constraints are not carried over from an old snapshot or window ID. Existing learned width constraints remain unchanged.
Evidence
After: both cases clear the height capability; the all-nil transition clears accepted sizing and restores full tile height.
python3 script/verify.py local --stage: build, all non-desktop Swift tests, workflow tests, and staging passed.DesktopE2ETests/testAppliedTargetConvergesWithRealWindowFrame: passed with Accessibility available; desktop session restored.Merge Danger
Door: two-way
Blast Radius: tiling
If optional native constraints are unavailable, compact acceptance is discarded and full tile height is requested.
Note
Respect native maximum window heights in tiled layout
WindowSizeConstraintsvalue, and theWindowmodel gains an optionalmaximumTiledHeightcarried through discovery inSnapshotEngine.makeWindow(WindowBorderPrivateProviders.swift, Window.swift).acceptedTiledSizesandacceptTiledWindowFramenow require a maximum tiled height; stale accepted sizes from unbounded windows are ignored (Layout.swift, RuntimeState.swift).Macroscope summarized 4b7df31.