perf(overview): prioritize and smooth preview loading - #112
Conversation
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR changes the production overview capture and rendering pipeline across multiple files, including capture prioritization and concurrency, wallpaper preloading, shared image processing, cross-fades, and dirty-region redraws. The resulting asynchronous coordination and visible existing-path behavior are broad enough to require human review. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Start the fade link on every replacement, cancel the desktop capture with the batch, rank cross-monitor previews without comparing panel-local coordinates, skip off-rect borders during localized redraws, and cap preview concurrency at three so at most four captures run at once.
|
Review feedback addressed in 4397dd4 (also merged main):
|
|
Concurrency: you're right, docs/plans/overview.md sets a two-capture bound. Reverted to 2 and window + desktop captures now share one limiter, so desktop capture still overlaps window previews without exceeding it. |
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
|
Cancellation: a worker cancelled while queued now releases its slot and returns without capturing (both window and desktop paths). |
…mings Fade the panel in over 140ms and cross-fade a replaced desktop image, both skipped for reduced motion. Decode the wallpaper when panels are prepared so the first open does not show black. Report open-to-first and open-to-last preview milliseconds in defi status.
|
Also in this PR now: panel fade-in on open (140ms), desktop-image cross-fade (250ms), wallpaper preloaded at panel preparation, and |
…nto perf/overview-preview-loading
|
Also in this PR now: panel fade-in on open (140ms), desktop-image cross-fade (250ms), wallpaper preloaded at panel preparation, and |
Summary
Testing
Note
Prioritize and smooth overview preview loading with capture limits and cross-fades
OverviewCaptureLimiteractor in OverviewPreviewCapture.swiftOverviewPresentationStateand formats them in the daemon status stringprogressivelyBlurredOverviewPreviewnow applies variable blur only to the title-band region instead of the whole preview; reveal timing tests in OverviewPreviewTests.swift are updated for the 0.45s defaultMacroscope summarized 763be1b.