fix: stabilize window focus and tiled frames - #110
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is a broad runtime behavior change across tiling, focus, scrolling, border presentation, and asynchronous Accessibility writes, with new state and coordination logic rather than a small isolated fix. The parking verification retry path also has an unresolved medium-severity concern about continuing beyond its intended deadline. Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more. |
There was a problem hiding this comment.
All reported issues were addressed across 23 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
- Log hotkey source PIDs and command input sources - Follow observed window bounds for idle border lanes
01e6e1f to
2033c65
Compare
There was a problem hiding this comment.
All reported issues were addressed across 7 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
Summary
Testing
Note
Stabilize window focus, tiled frame acceptance, and border parking verification
columnLayoutWidthandfocusedColumnLeftScrollOffset/focusedColumnTargetScrollOffsetin WorkspaceScrolling.swift changed signatures and gained accepted-size-aware widths; column widths and scroll offsets can shrink or expand when windows accept sizes different from the preferred layoutMacroscope summarized a0561b5.