Repository navigation
XNNPACK: Skip the bf16 GEMM runtime tests in fbcode - #24527
digantdesai wants to merge 1 commit into
Conversation
Summary: Skip three of the new bf16 tests in fbcode: `test_bf16_bmm`, `test_enable_bf16_fuses_batch_norm_into_a_linear` and `test_enable_bf16_runs_an_attention_block`. They are unchanged and still run in OSS. The check is `is_fbcode()` from `executorch.export.utils`. Differential Revision: D129426465
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24527
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 5 PendingAs of commit e41dc43 with merge base f1240a2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@digantdesai has exported this pull request. If you are a Meta employee, you can view the originating Diff in D129426465. |
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the fbcode-specific bf16 test skips and supporting dependency updates.
No open issues 🎉
What changed in this PR
This PR skips three XNNPACK bf16 runtime tests in fbcode while preserving their execution in OSS.
Changes:
- Adds
is_fbcode()skip guards to the bf16 BMM, batch-normalization fusion, and attention-block tests. - Adds the corresponding export utility dependencies to the Buck test targets.
| File | Description |
|---|---|
backends/xnnpack/test/test_xnnpack_partitioner.py |
Skips the bf16 fusion and attention-block tests in fbcode. |
backends/xnnpack/test/ops/test_bmm.py |
Skips the bf16 BMM test in fbcode. |
backends/xnnpack/test/BUCK |
Adds dependencies for the imported is_fbcode() helper. |
Review effort: Balanced
This PR needs a
|
Summary: Skip three of the new bf16 tests in fbcode:
test_bf16_bmm,test_enable_bf16_fuses_batch_norm_into_a_linearandtest_enable_bf16_runs_an_attention_block. They are unchanged and still run in OSS. The check isis_fbcode()fromexecutorch.export.utils.Differential Revision: D129426465