Skip to content

XNNPACK: Skip the bf16 GEMM runtime tests in fbcode - #24527

Open
digantdesai wants to merge 1 commit into
pytorch:mainfrom
digantdesai:export-D129426465
Open

digantdesai wants to merge 1 commit into
pytorch:mainfrom
digantdesai:export-D129426465

Conversation

@digantdesai

Copy link
Copy Markdown
Contributor

Summary: Skip three of the new bf16 tests in fbcode: test_bf16_bmm, test_enable_bf16_fuses_batch_norm_into_a_linear and test_enable_bf16_runs_an_attention_block. They are unchanged and still run in OSS. The check is is_fbcode() from executorch.export.utils.

Differential Revision: D129426465

Summary: Skip three of the new bf16 tests in fbcode: `test_bf16_bmm`, `test_enable_bf16_fuses_batch_norm_into_a_linear` and `test_enable_bf16_runs_an_attention_block`. They are unchanged and still run in OSS. The check is `is_fbcode()` from `executorch.export.utils`.

Differential Revision: D129426465
Copilot AI balanced review requested due to automatic review settings November 3, 2026 20:53
@pytorch-bot

pytorch-bot Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24527

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 5 Pending

As of commit e41dc43 with merge base f1240a2 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 3, 2026
@meta-codesync

meta-codesync Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

@digantdesai has exported this pull request. If you are a Meta employee, you can view the originating Diff in D129426465.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are recorded for the fbcode-specific bf16 test skips and supporting dependency updates.

No open issues 🎉

What changed in this PR

This PR skips three XNNPACK bf16 runtime tests in fbcode while preserving their execution in OSS.

Changes:

  • Adds is_fbcode() skip guards to the bf16 BMM, batch-normalization fusion, and attention-block tests.
  • Adds the corresponding export utility dependencies to the Buck test targets.
File Description
backends/​xnnpack/​test/​test_xnnpack_partitioner.py Skips the bf16 fusion and attention-block tests in fbcode.
backends/​xnnpack/​test/​ops/​test_bmm.py Skips the bf16 BMM test in fbcode.
backends/​xnnpack/​test/​BUCK Adds dependencies for the imported is_fbcode() helper.

Review effort: Balanced

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants