Repository navigation
Install: stop pulling every submodule when a required one is missing - #24523
Open
JakeStevens wants to merge 1 commit into
Open
JakeStevens wants to merge 1 commit into
JakeStevens wants to merge 1 commit into
Conversation
check_and_update_submodules() ran a bare `git submodule update --init --recursive` whenever a required submodule was absent, which fetched all ~24 submodules including llama.cpp and mlx, even though the default build uses neither. Update only the missing required paths instead, and mark llama.cpp shallow like mlx so it is no longer cloned with full history. This PR was authored with the assistance of Claude Code.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24523
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 3 Cancelled Jobs, 2 Pending, 1 Unrelated FailureAs of commit 309f6cc with merge base 4628b2b ( NEW FAILURES - The following jobs have failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`install_executorch.py` runs a bare `git submodule update --init --recursive` whenever a required submodule is missing, which fetches all ~24 submodules, including llama.cpp and mlx. The default build uses neither (`EXECUTORCH_BUILD_NATIVE_GGML` defaults to OFF).
This updates only the missing required paths, and marks llama.cpp `shallow = true` (as mlx already is) so it is no longer cloned with full history. The shallow setting also helps anyone who clones with `--recursive` before the install script runs.
Not tested end to end: I haven't run the installer from a clean checkout, and haven't confirmed that a depth-1 fetch of the pinned llama.cpp commit works when it isn't a branch tip. lintrunner wasn't available locally.
Authored with Claude Code.