Repository navigation
Remove duplicate fuse_batch_norm_with_linear target - #24213
Merged
JakeStevens merged 1 commit intoOct 27, 2026
Merged
Conversation
`backends/transforms/targets.bzl` defines the `fuse_batch_norm_with_linear` `python_library` twice: once from pytorch#24192 and again from the squash of pytorch#24193, which picked up the block a second time when the PR branch was merged with `main`. Buck refuses to register the same target twice, so loading `//backends/transforms/...` fails, which breaks `unittest-buck`. Delete the second, identical definition.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24213
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 19 PendingAs of commit c6bc155 with merge base 7aca03b ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This PR needs a
|
rascani
approved these changes
Oct 27, 2026
Erik-Lundell
pushed a commit
to Erik-Lundell/executorch
that referenced
this pull request
Oct 28, 2026
`backends/transforms/targets.bzl` defines the `fuse_batch_norm_with_linear` `python_library` twice (lines 138 and 152). The first copy comes from pytorch#24192. The second came in with the squash of pytorch#24193, whose branch picked up the block again when it was merged with `main`. Buck refuses to register the same target twice, so any command that loads `//backends/transforms/...` fails: ``` error: Attempted to register target root//backends/transforms:fuse_batch_norm_with_linear twice ``` This breaks `unittest-buck` on `main` and on open PRs. This change deletes the second, identical definition. No other targets in the file are duplicated. ### Test plan - Checked that `targets.bzl` now defines each target name once. - CI: `unittest-buck` should get past the `buck2 query` step.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
backends/transforms/targets.bzldefines thefuse_batch_norm_with_linearpython_librarytwice (lines 138 and 152). The first copy comes from #24192. The second came in with the squash of #24193, whose branch picked up the block again when it was merged withmain.Buck refuses to register the same target twice, so any command that loads
//backends/transforms/...fails:This breaks
unittest-buckonmainand on open PRs.This change deletes the second, identical definition. No other targets in the file are duplicated.
Test plan
targets.bzlnow defines each target name once.unittest-buckshould get past thebuck2 querystep.