Repository navigation
Accept empty tensor bindings in CPUBackend execute (#24195) - #24195
Merged
Merged
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/24195
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 070df8b with merge base 8739d28 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
Contributor
|
@JakeStevens has exported this pull request. If you are a Meta employee, you can view the originating Diff in D126930703. |
digantdesai
approved these changes
Oct 27, 2026
digantdesai
left a comment
digantdesai
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
This PR needs a
|
meta-codesync
Bot
changed the title
JakeStevens
force-pushed
the
export-D126930703
branch
from
October 27, 2026 15:32
9293023 to
fd327ae
Compare
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Oct 27, 2026
Summary: The CPU delegate rejected any binding whose strides/dim-order were not canonical-contiguous, including empty (0-byte) tensors whose layout is meaningless: PyTorch does not canonicalize strides for 0-size dims, so e.g. a (0,0,0,0,0) input arrives with dim-order != identity and fails with 0x12 (InvalidArgument). Skip the contiguity check for 0-byte bindings; the input/output memcpys already skip empty buffers, and providers handle 0-size execution. Reviewed By: digantdesai Differential Revision: D126930703
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Oct 27, 2026
Summary: The CPU delegate rejected any binding whose strides/dim-order were not canonical-contiguous, including empty (0-byte) tensors whose layout is meaningless: PyTorch does not canonicalize strides for 0-size dims, so e.g. a (0,0,0,0,0) input arrives with dim-order != identity and fails with 0x12 (InvalidArgument). Skip the contiguity check for 0-byte bindings; the input/output memcpys already skip empty buffers, and providers handle 0-size execution. Reviewed By: digantdesai Differential Revision: D126930703
JakeStevens
force-pushed
the
export-D126930703
branch
2 times, most recently
from
October 27, 2026 16:10
21ced12 to
4f24839
Compare
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Oct 27, 2026
Summary: The CPU delegate rejected any binding whose strides/dim-order were not canonical-contiguous, including empty (0-byte) tensors whose layout is meaningless: PyTorch does not canonicalize strides for 0-size dims, so e.g. a (0,0,0,0,0) input arrives with dim-order != identity and fails with 0x12 (InvalidArgument). Skip the contiguity check for 0-byte bindings; the input/output memcpys already skip empty buffers, and providers handle 0-size execution. Reviewed By: digantdesai Differential Revision: D126930703
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Oct 27, 2026
Summary: The CPU delegate rejected any binding whose strides/dim-order were not canonical-contiguous, including empty (0-byte) tensors whose layout is meaningless: PyTorch does not canonicalize strides for 0-size dims, so e.g. a (0,0,0,0,0) input arrives with dim-order != identity and fails with 0x12 (InvalidArgument). Skip the contiguity check for 0-byte bindings; the input/output memcpys already skip empty buffers, and providers handle 0-size execution. Reviewed By: digantdesai Differential Revision: D126930703
JakeStevens
force-pushed
the
export-D126930703
branch
from
October 27, 2026 20:23
4f24839 to
ecd8801
Compare
JakeStevens
added a commit
to JakeStevens/executorch
that referenced
this pull request
Oct 27, 2026
Summary: The CPU delegate rejected any binding whose strides/dim-order were not canonical-contiguous, including empty (0-byte) tensors whose layout is meaningless: PyTorch does not canonicalize strides for 0-size dims, so e.g. a (0,0,0,0,0) input arrives with dim-order != identity and fails with 0x12 (InvalidArgument). Skip the contiguity check for 0-byte bindings; the input/output memcpys already skip empty buffers, and providers handle 0-size execution. Reviewed By: digantdesai Differential Revision: D126930703
JakeStevens
force-pushed
the
export-D126930703
branch
from
October 27, 2026 21:06
ecd8801 to
5e32001
Compare
Summary: Pull Request resolved: pytorch#24195 The CPU delegate rejected any binding whose strides/dim-order were not canonical-contiguous, including empty (0-byte) tensors whose layout is meaningless: PyTorch does not canonicalize strides for 0-size dims, so e.g. a (0,0,0,0,0) input arrives with dim-order != identity and fails with 0x12 (InvalidArgument). Skip the contiguity check for 0-byte bindings; the input/output memcpys already skip empty buffers, and providers handle 0-size execution. Reviewed By: digantdesai Differential Revision: D126930703
JakeStevens
force-pushed
the
export-D126930703
branch
from
October 27, 2026 21:10
5e32001 to
070df8b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The CPU delegate rejected any binding whose strides/dim-order were not canonical-contiguous, including empty (0-byte) tensors whose layout is meaningless: PyTorch does not canonicalize strides for 0-size dims, so e.g. a (0,0,0,0,0) input arrives with dim-order != identity and fails with 0x12 (InvalidArgument).
Skip the contiguity check for 0-byte bindings; the input/output memcpys already skip empty buffers, and providers handle 0-size execution.
Reviewed By: digantdesai
Differential Revision: D126930703