Cortex-M: preserve unsupported transpose ranks - #22571
Open
rascani wants to merge 1 commit into
Open
Conversation
Keep int8 permutes with ranks outside 1-4 on portable operators because cortex_m::transpose only supports up to four dimensions. Add a rank-5 dialect regression test. Authored with Codex.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22571
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2f7b6fc with merge base 77fb78d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep int8
aten.permute_copynodes with ranks outside 1–4 on the portable operator. The Cortex-M transpose kernel only supports ranks 1–4, so lowering a rank-5 permutation produced a program that failed when loaded by the runtime.The existing supported-rank FVP coverage remains unchanged. A new dialect test verifies that a rank-5 int8 permutation stays as
aten.permute_copy.Test plan
source examples/arm/arm-scratch/setup_path.sh && python -m pytest --config-file=backends/arm/test/pytest.ini backends/cortex_m/test/ops/test_transpose.pylintrunner -m origin/mainAI-assisted: Codex.