Skip to content

Arm backend: Support permute-removal for TOSA ops#19277

Open
oscarandersson8218 wants to merge 1 commit intopytorch:mainfrom
oscarandersson8218:permute_removal_tosa_ops
Open

Arm backend: Support permute-removal for TOSA ops#19277
oscarandersson8218 wants to merge 1 commit intopytorch:mainfrom
oscarandersson8218:permute_removal_tosa_ops

Conversation

@oscarandersson8218
Copy link
Copy Markdown
Collaborator

@oscarandersson8218 oscarandersson8218 commented May 4, 2026

Adds a TOSA specific variant of RemovePermutesAroundElementwiseOps that makes sure that elementwise TOSA backend dialect operators also are covered by this pass. As of now this includes TABLE and RESCALE.

cc @digantdesai @freddan80 @per @zingo @mansnils @Sebastian-Larsson @robell

Adds a TOSA specific variant of RemovePermutesAroundElementwiseOps that
makes sure that elementwise TOSA backend dialect operators also are
covered by this pass. As of now this includes TABLE and RESCALE.

Signed-off-by: Oscar Andersson <oscar.andersson@arm.com>
Change-Id: Ia834a5b641af33419d1210be95b5ad7566e857b3
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 4, 2026

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19277

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 Cancelled Jobs, 3 Unrelated Failures

As of commit b765035 with merge base 69989b7 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

BROKEN TRUNK - The following jobs failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 4, 2026
@github-actions github-actions Bot added ciflow/trunk module: arm Issues related to arm backend labels May 4, 2026
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes labels May 4, 2026
RewritePadPass(),
RewriteSlicePass(),
FuseViewCopyTransformPass(),
RemovePermutesAroundElementwiseOps(),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can instantiate earlier and add ops, like:

remove_permute_around_elementwise_ops_tosa = RemovePermutesAroundElementwiseOps()
remove_permute_around_elementwise_ops_tosa.permutable_ops | {
    exir_ops.backend.tosa.RESCALE.default,
    exir_ops.backend.tosa.TABLE.default,
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. module: arm Issues related to arm backend partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: none Do not include this in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants