Skip to content

fix: support SymInt for slice_scatter_decomposition#4236

Open
zewenli98 wants to merge 1 commit intomainfrom
fix_slice_scatter_decomposition
Open

fix: support SymInt for slice_scatter_decomposition#4236
zewenli98 wants to merge 1 commit intomainfrom
fix_slice_scatter_decomposition

Conversation

@zewenli98
Copy link
Copy Markdown
Collaborator

@zewenli98 zewenli98 commented May 6, 2026

Description

Add support for SymInt inputs in slice_scatter_decomposition.

This fixes a crash in ZoomASR.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project (You can use the linters)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas and hacks
  • I have made corresponding changes to the documentation
  • I have added tests to verify my fix or my feature
  • New and existing unit tests pass locally with my changes
  • I have added the relevant labels to my PR in so that relevant reviewers are notified

@zewenli98 zewenli98 requested review from apbose and narendasan May 6, 2026 04:41
@meta-cla meta-cla Bot added the cla signed label May 6, 2026
@github-actions github-actions Bot added component: tests Issues re: Tests component: lowering Issues re: The lowering / preprocessing passes component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: api [Python] Issues re: Python API component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths labels May 6, 2026
@zewenli98 zewenli98 mentioned this pull request May 6, 2026
Closed
7 tasks
@zewenli98 zewenli98 self-assigned this May 6, 2026
narendasan
narendasan approved these changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@narendasan narendasan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot requested a review from narendasan May 6, 2026 18:52
apbose
apbose approved these changes May 6, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@apbose apbose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apbose apbose apbose approved these changes

@narendasan narendasan Awaiting requested review from narendasan

Assignees

@zewenli98 zewenli98

Labels

cla signed component: api [Python] Issues re: Python API component: conversion Issues re: Conversion stage component: core Issues re: The core compiler component: dynamo Issues relating to the `torch.compile` or `torch._dynamo.export` paths component: lowering Issues re: The lowering / preprocessing passes component: tests Issues re: Tests needs-release-cherrypick

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zewenli98 @narendasan @apbose