Skip to content

Add customizable navigation keybindings. - #121

Closed
guttermonk wants to merge 3 commits into
pythops:masterfrom
guttermonk:master
Closed

guttermonk wants to merge 3 commits into
pythops:masterfrom
guttermonk:master

Conversation

@guttermonk

Copy link
Copy Markdown

This PR adds configurable keybindings for navigation keys, complementing the existing customizable action keys.

Closes #120.

New Configuration Options

Added a [navigation] section to the config file with the following options:

Key Default Description
up k Scroll up in lists
down j Scroll down in lists
left h Switch focus to previous section
right l Switch focus to next section
quit q Quit the application
select (space) Connect/disconnect or pair device

Example Configuration

[navigation]
up = "i"
down = "e"
left = "n"
right = "o"
quit = "q"
select = " "

Changes

  • src/config.rs: Added Navigation struct with configurable keys and defaults
  • src/handler.rs: Updated key event handling to use configurable navigation keys
  • src/help.rs: Help text now displays the actual configured keys
  • Readme.md: Documented the new [navigation] config section
  • flake.nix: Use rust-overlay for package builds (ensures compatible Rust version)

Notes

  • Arrow keys (Up/Down) and Tab/BackTab continue to work as hardcoded alternatives for accessibility
  • Enter remains hardcoded for connect/disconnect/pair actions
  • Ctrl+C remains hardcoded for quit

@pythops

pythops commented Jan 26, 2026

Copy link
Copy Markdown
Owner

There are lof changes in the PR. I have stated in the Readme that an issue should exists and discussed before a PR can be opened. It takes so much mental energy to review unsolicited changes to be honest.
Can you break changes it to include only navigation keys as mentioned in the title and nothing else. And for the other changes, please open an issue first if it not there

@pythops

pythops commented Aug 26, 2026

Copy link
Copy Markdown
Owner

let's have an issue of discussion first before any changes

@pythops pythops closed this Aug 26, 2026
@eekhof

eekhof commented Oct 21, 2026

Copy link
Copy Markdown

@pythops Would you be willing to pull something like this if I isolate only the relevant bits for customizable navkeys? Or would you rather like a completely new patch from scratch?

@pythops

pythops commented Oct 21, 2026

Copy link
Copy Markdown
Owner

I don't want to add more customization for the keys honestly. The only thing i can accept is a theme, the way it is implemented in impala pythops/impala#151. if you want to add it, fine, you can create an issue for it and then send a PR similar to the one with impala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add custom keybinds for nav keys

3 participants