Skip to content

Skip the legacy asyncio coroutine test when its API is unavailable - #819

Merged
AlexWaygood merged 2 commits into
python:mainfrom
Khabib73:patch-1
Nov 9, 2026
Merged

AlexWaygood merged 2 commits into
python:mainfrom
Khabib73:patch-1

Conversation

@Khabib73

@Khabib73 Khabib73 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Closes #809

@python-cla-bot

python-cla-bot Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed

@srittau

srittau commented Nov 3, 2026

Copy link
Copy Markdown
Collaborator

Dupe.

@srittau srittau closed this Nov 3, 2026
@Khabib73

Khabib73 commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor Author

#811 is no longer active :(
@srittau

@Khabib73

Khabib73 commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

Since #811 has been inactive for 2 weeks and hasn't signed the CLA, is it still the intended path forward? If so, what's the plan for it? If not, would you consider reopening this PR? @srittau @JelleZijlstra

@Khabib73

Khabib73 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Hi @AlexWaygood — #811 has been inactive for 3 weeks and still hasn’t signed the CLA. Could you close #811 and reopen my PR instead? Thanks!

@srittau srittau reopened this Nov 9, 2026
@Khabib73

Khabib73 commented Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Thanks!

@codecov

codecov Bot commented Nov 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.50%. Comparing base (8d823bb) to head (0d1b5ad).

@@           Coverage Diff           @@
##             main     #819   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files           3        3           
  Lines        7859     7860    +1     
=======================================
+ Hits         7427     7428    +1     
  Misses        432      432           
Flag Coverage Δ
3.10 88.85% <100.00%> (+<0.01%) ⬆️
3.10.4 88.85% <100.00%> (+<0.01%) ⬆️
3.11 88.02% <100.00%> (+<0.01%) ⬆️
3.11.0 87.27% <100.00%> (+<0.01%) ⬆️
3.12 87.96% <100.00%> (+<0.01%) ⬆️
3.12.0 87.95% <100.00%> (+<0.01%) ⬆️
3.13 83.39% <100.00%> (+<0.01%) ⬆️
3.13.0 84.09% <100.00%> (+<0.01%) ⬆️
3.14 79.53% <100.00%> (+<0.01%) ⬆️
3.14.0 80.25% <100.00%> (+<0.01%) ⬆️
3.15 76.71% <100.00%> (+<0.01%) ⬆️
3.15.0 76.71% <100.00%> (+<0.01%) ⬆️
pypy3.10 88.68% <100.00%> (+<0.01%) ⬆️
pypy3.11 87.88% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/test_typing_extensions.py 98.01% <100.00%> (+<0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AlexWaygood AlexWaygood changed the title Closes #809 Skip the legacy asyncio coroutine test when its API is unavailable- #811 Nov 9, 2026
@AlexWaygood AlexWaygood changed the title Skip the legacy asyncio coroutine test when its API is unavailable- #811 Skip the legacy asyncio coroutine test when its API is unavailable Nov 9, 2026
@AlexWaygood
AlexWaygood merged commit a202455 into python:main Nov 9, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3.16.0a1 removed asyncio.coroutines.iscoroutinefunction(), still used in tests

3 participants