Repository navigation
typeddict: disallow nesting Required in itself - #2374
Merged
Merged
Conversation
jorenham
approved these changes
Oct 20, 2026
jorenham
left a comment
jorenham
left a comment
Collaborator
There was a problem hiding this comment.
I don't see the harm in stacking these, but neither is there a use-case for this, so removing the self-nesting conformance check would also be fine as far as I'm concerned. Either way, this improves consistency, so it's a ++1 from me ;)
davidhalter
approved these changes
Oct 20, 2026
Member
Author
|
Not caring about it is also fine with me, but it seems like more work since current type checkers do emit an error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2372