Repository navigation
Conversation
This comment has been minimized.
This comment has been minimized.
xiehuanyi
changed the title
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
requested changes
Oct 12, 2026
srittau
left a comment
srittau
left a comment
Collaborator
There was a problem hiding this comment.
Please don't include the tests. Typeshed tests are never run, only tested against type checkers, so these tests only check that the type checkers work as expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileIO,BufferedReader,BufferedWriter, andBufferedRandomaccept integer-like seek positions, includingnumpy.int64, but their stubs currently requireint. Valid offset arguments therefore produce type errors.Use
SupportsIndexfor these four seek position parameters. Regression checks retain the integer return type and rejection of string offsets. TheBytesIOannotation stays compatible with existing subclasses that declare an integer-only offset, with a regression check for that shape.Validation: focused strict mypy and Pyright pass. Official scoped mypy checks pass for Python 3.10–3.15,
_ioandiopass stubtest on Python 3.12.13, and all applicable pre-commit hooks pass. Runtime checks cover custom index objects and NumPy integer offsets, including the pure Python buffered implementations.Developed, reviewed, and tested with AI assistance (Codex).