Skip to content

added password_reset and password_reset_done templates - #2886

Open
jamie-ferguson wants to merge 2 commits into
python:mainfrom
jamie-ferguson:bugfix-for-missing-password-reset-templates
Open

jamie-ferguson wants to merge 2 commits into
python:mainfrom
jamie-ferguson:bugfix-for-missing-password-reset-templates

Conversation

@jamie-ferguson

Copy link
Copy Markdown

Description

Fixes missing password reset templates in the accounts pages.

Previously, attempting to reset a password would show unstyled pages at the following urls
/accounts/password/reset
/accounts/password/reset/done/

This PR adds two new template files which fixes this.

Tested locally using the Docker setup and triggering the password reset workflow.

Closes

Closes #2617

@jefftriplett

Copy link
Copy Markdown
Member

Thanks Jamie, and sorry this sat so long. I checked it out locally and both pages render correctly inside the site chrome, the styling matches login.html, and CI is green.

One thing before we merge: this covers the first half of the reset flow but not the second. The page a user lands on from the emailed link still falls through to allauth's own templates, with no site nav at all:

/accounts/password/reset/key/<key>/
  account/password_reset_from_key.html
  account/base_entrance.html
  allauth/layouts/entrance.html
  allauth/layouts/base.html

So requesting a reset looks right, then clicking the link in the email drops you onto a bare allauth page to type the new password. The two still needed are:

  • templates/account/password_reset_from_key.html
  • templates/account/password_reset_from_key_done.html

They should be short, in the same shape as the two here. If you would like to finish it off, great. If you would rather not, say the word and we will add them and get this landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: RESET password page don't follow same styling as signin page

3 participants