Skip to content

gh-151678: Add tests for tkinter.dnd#151780

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:test-tkinter-dnd
Jun 20, 2026
Merged

gh-151678: Add tests for tkinter.dnd#151780
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:test-tkinter-dnd

Conversation

@serhiy-storchaka

Copy link
Copy Markdown
Member

Drive the drag-and-drop protocol (dnd_start and the DndHandler enter/motion/commit, leave/cancel and end callbacks).
winfo_containing(), the thin Tk wrapper used to locate the target, is stubbed so the tests exercise only the DndHandler dispatch logic and do not depend on the window being visible and unobscured.

Drive the drag-and-drop protocol (dnd_start and the DndHandler enter/
motion/commit, leave/cancel and end callbacks).  winfo_containing(), the
thin Tk wrapper used to locate the target, is stubbed so the tests
exercise only the DndHandler dispatch logic and do not depend on the
window being visible and unobscured.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting core review labels Jun 20, 2026
@serhiy-storchaka serhiy-storchaka added skip news needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 20, 2026
@serhiy-storchaka serhiy-storchaka merged commit 2a126a5 into python:main Jun 20, 2026
97 of 101 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Jun 20, 2026

Copy link
Copy Markdown

GH-151790 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 20, 2026
@bedevere-app

bedevere-app Bot commented Jun 20, 2026

Copy link
Copy Markdown

GH-151791 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Jun 20, 2026
@bedevere-app

bedevere-app Bot commented Jun 20, 2026

Copy link
Copy Markdown

GH-151792 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Jun 20, 2026
serhiy-storchaka added a commit that referenced this pull request Jun 20, 2026
Drive the drag-and-drop protocol (dnd_start and the DndHandler enter/
motion/commit, leave/cancel and end callbacks).
(cherry picked from commit 2a126a5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka added a commit that referenced this pull request Jun 20, 2026
Drive the drag-and-drop protocol (dnd_start and the DndHandler enter/
motion/commit, leave/cancel and end callbacks).
(cherry picked from commit 2a126a5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
serhiy-storchaka added a commit that referenced this pull request Jun 20, 2026
Drive the drag-and-drop protocol (dnd_start and the DndHandler enter/
motion/commit, leave/cancel and end callbacks).
(cherry picked from commit 2a126a5)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
@serhiy-storchaka serhiy-storchaka deleted the test-tkinter-dnd branch June 20, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant