Conversation
This comment was marked as resolved.
This comment was marked as resolved.
StanFromIreland
left a comment
There was a problem hiding this comment.
Can you please optimise the images, unless you already have? (E.g. with OptiPNG: find . -name '*.png' | xargs optipng -o7) If you're unable to please let me know and I can do it.
2bfe992 to
9b6bc0c
Compare
|
Done! Thanks for the suggestion! Let me know if there's something else I can do to help |
9b6bc0c to
c0cce8a
Compare
|
Yep, they were indeed identical. I should have thought about it 🙈 Thanks! |
|
No worries! Thanks for making the changes, just a little note for the future, please avoid force pushing. |
StanFromIreland
left a comment
There was a problem hiding this comment.
LGTM, thanks, I'll leave this for Pablo.
| -------------- | ||
|
|
||
| .. image:: tachyon-logo.png | ||
| .. image:: ../../Lib/profiling/sampling/_assets/tachyon-logo.png |
There was a problem hiding this comment.
CAn't we leave the old link? I don't really like having this path hardcoded.
There was a problem hiding this comment.
not a strong opinion here, but we can either have a replicate image in two places or having a link to the second lib, or I'm not seeing how to do both :)
There was a problem hiding this comment.
Err, what I meant is that I would have preferred to keep tachyon-logo.png as the image's directive argument and not the ../../Lib/profiling/sampling/_assets/tachyon-logo.png one. The Sphinx docs should have added the asset path in conf.py I think?
There was a problem hiding this comment.
Oh, there were TWO files. Ok. I think you can just add Lib/profiling/sampling/_assets as an asset to search within for Sphinx to pick it up. It's been a while since I played with assets so I may have missed something.
|
Please avoid using the Update Branch button unless necessary (e.g. fixing conflicts or jogging the CI) as it uses valuable resources. For more information please see the devguide. |
Summary
Updates the Tachyon logo with a vectorial design and refreshed colors
Changes
The previous logo design was a draft that needed to be updated with the final version. Updated:
Doc/library/tachyon-logo.pngLib/profiling/sampling/_assets/tachyon-logo.pngwith new design and colors
And verified that locally the logo renders correctly:
cd Doc make venv make html open build/html/library/profiling.sampling.htmlSee gh-140727.
📚 Documentation preview 📚: https://cpython-previews--148965.org.readthedocs.build/