Skip to content

gh-148919: Make test_redirect_no_path independent of proxy environment variables#148920

Open
sendaoYan wants to merge 1 commit intopython:mainfrom
sendaoYan:gh-148919
Open

gh-148919: Make test_redirect_no_path independent of proxy environment variables#148920
sendaoYan wants to merge 1 commit intopython:mainfrom
sendaoYan:gh-148919

Conversation

@sendaoYan
Copy link
Copy Markdown

@sendaoYan sendaoYan commented Apr 23, 2026

Summary
test.test_urllib2.HandlerTests.test_redirect_no_path can fail when proxy-related environment variables are set (for example, http_proxy / HTTP_PROXY).

This change makes the test self-contained by clearing proxy-related environment variables within the test via test.support.os_helper.EnvironmentVarGuard.

Rationale
The test is intended to verify relative redirect behavior (Location: ?query) and should not depend on external shell/network proxy configuration.

When proxy env vars are active, request targets may be sent in absolute-form (http://python.org/path) instead of origin-form (/path), which breaks the current assertion and introduces environment-dependent failures.

Changes
Update Lib/test/test_urllib2.py in test_redirect_no_path:
Add EnvironmentVarGuard
Remove proxy-related variables (lowercase and uppercase variants, including no_proxy / NO_PROXY) for the duration of the test

@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Apr 23, 2026
@bedevere-app
Copy link
Copy Markdown

bedevere-app Bot commented Apr 23, 2026

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@sendaoYan
Copy link
Copy Markdown
Author

Test-fix only, I think this PR should add a label 'skip news'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants